Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md code sample confusion #360

Closed
t-aniba opened this issue Jun 7, 2013 · 0 comments
Closed

README.md code sample confusion #360

t-aniba opened this issue Jun 7, 2013 · 0 comments
Milestone
0.4.4 - sprint 3

Comments

@t-aniba
Copy link
Contributor

t-aniba commented Jun 7, 2013

PM: 0.5
Dev: 0
Test: 0
Currently in the repo README.md code sample containerPermissions is never used:

// Set anonymous access on the container.
BlobContainerPermissions containerPermissions;
containerPermissions = new BlobContainerPermissions();

This is bad code and can be confusing to beginners.
@ghost ghost assigned t-aniba Jun 7, 2013
@t-aniba t-aniba closed this as completed Jun 7, 2013
@t-aniba t-aniba reopened this Jun 7, 2013
@t-aniba t-aniba mentioned this issue Jun 10, 2013
Merged
t-aniba added a commit that referenced this issue Jun 11, 2013
@t-aniba
Merge pull request #362 from t-aniba/dev
921395a 
Issue #360: README.md code sample confusion
@t-aniba t-aniba closed this as completed Jun 11, 2013
@t-aniba t-aniba removed their assignment Apr 1, 2014
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
@t-aniba
fixed README.md fixes Azure#360
a6ccec7 
- code sample now uses containerPermissions variable
- added java and xml tags for syntax highlighting
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
@t-aniba
Merge pull request Azure#362 from t-aniba/dev
ae68f2e 
Issue Azure#360: README.md code sample confusion
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Mar 4, 2019
@rickle-msft
Merge pull request Azure#360 from rickle-msft/New-Storage-SDK-V10-Pre…
549b1ae 
…view-dev

New storage sdk v10 preview dev
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this issue Mar 21, 2019
@RikkiGibson
Perform response deserialization in HttpPipeline (Azure#360)
47f7cd1 
* Add DecodingPolicyFactory. Fix client-runtime tests.

* Fix test failures mainly by reverting to older impls

* Rename inner class

* Fix checkstyle

* Cleanup

* Remove unused methods

* RestResponse implements Closeable

* Add null check to DecodingPolicy

* Fixes based on self-review

* Fixes from review feedback
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.4 - sprint 3
Development

No branches or pull requests
1 participant
@t-aniba