Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework ReceiveLinkHandler to enable delivery buffer draining upon arrival on Qpid thread #33701

Closed
anuchandy opened this issue Feb 23, 2023 · 2 comments
Closed

Rework ReceiveLinkHandler to enable delivery buffer draining upon arrival on Qpid thread #33701

anuchandy opened this issue Feb 23, 2023 · 2 comments
Assignees
@anuchandy
Labels
amqp Label for tracking issues related to AMQP Azure.Core azure-core Event Hubs Service Bus

Comments

@anuchandy
Copy link
Member

anuchandy commented Feb 23, 2023 •
edited
Loading

Rework ReceiveLinkHandler to

  1. Enable delivery buffer draining upon arrival on Qpid thread.
  2. Expose Flux of Message instead of Flux of Delivery.
  3. As a consequence of the drain on delivery, the
    decodeDelivery in ReactorReceiver and ServiceBusReactorReceiver will be removed.

Benefits: Reduce thread hopping in Event Hubs and Service Bus and fixes an edge case of SB receiver hanging.

Impl time notes: We may need a new internal ReceiveLinkHandler2 to co-exist with the current ReceiveLinkHandler for the short term while removing legacy ReceiveLinkHandler dependency over multiple iterations.
@anuchandy anuchandy added Event Hubs Service Bus Azure.Core azure-core amqp Label for tracking issues related to AMQP labels Feb 23, 2023
@anuchandy anuchandy self-assigned this Feb 23, 2023
This was referenced Feb 23, 2023
Closed
Closed
Closed
Closed
Closed
@anuchandy
Copy link
Member Author

This is implemented in the PR #34854

@anuchandy
Copy link
Member Author

Work implemented in https://central.sonatype.com/artifact/com.azure/azure-core-amqp/2.9.0

@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anuchandy anuchandy

Labels
amqp Label for tracking issues related to AMQP Azure.Core azure-core Event Hubs Service Bus
Projects
Java SDKs Azure Core
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anuchandy