Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic module names for Spring Cloud Azure modules #27350

Closed
saragluna opened this issue Mar 1, 2022 · 1 comment · Fixed by #27362
Closed

Add automatic module names for Spring Cloud Azure modules #27350

saragluna opened this issue Mar 1, 2022 · 1 comment · Fixed by #27362
Assignees
@hui1110
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@saragluna
Copy link
Member

saragluna commented Mar 1, 2022 •
edited
Loading

We chose to add Automatic Module Name over adding module-info.java for each Spring Cloud Azure module for Java9 modules suppport. Here's the list of module names we should set for each one:

com.azure.spring.cloud.core
com.azure.spring.cloud.service
com.azure.spring.cloud.resourcemanager
com.azure.spring.cloud.trace.sleuth
com.azure.spring.cloud.actuator
com.azure.spring.cloud.actuator.autoconfigure
com.azure.spring.cloud.autoconfigure
com.azure.spring.cloud.starter
com.azure.spring.cloud.starter.active.directory
com.azure.spring.cloud.starter.active.directory.b2c
com.azure.spring.cloud.starter.actuator
com.azure.spring.cloud.starter.appconfiguration
com.azure.spring.cloud.starter.cosmos
com.azure.spring.cloud.starter.data.cosmos
com.azure.spring.cloud.starter.eventhubs
com.azure.spring.cloud.starter.keyvault.certificates
com.azure.spring.cloud.starter.keyvault.secrets
com.azure.spring.cloud.starter.servicebus
com.azure.spring.cloud.starter.servicebus.jms
com.azure.spring.cloud.starter.storage.blob
com.azure.spring.cloud.starter.storage.file-share
com.azure.spring.cloud.starter.storage.queue
com.azure.spring.cloud.starter.integration.eventhubs
com.azure.spring.cloud.starter.integration.servicebus
com.azure.spring.cloud.starter.integration.storage.queue
com.azure.spring.cloud.starter.stream.eventhubs
com.azure.spring.cloud.starter.stream.servicebus
com.azure.spring.messaging
com.azure.spring.messaging.eventhubs
com.azure.spring.messaging.servicebus
com.azure.spring.messaging.storage.queue
com.azure.spring.integration.core
com.azure.spring.integration.eventhubs
com.azure.spring.integration.servicebus
com.azure.spring.integration.storage.queue
com.azure.spring.cloud.stream.binder.eventhubs
com.azure.spring.cloud.stream.binder.eventhubs.core
com.azure.spring.cloud.stream.binder.servicebus
com.azure.spring.cloud.stream.binder.servicebus.core

We should also make sure these module names match with the root package in most libraries.

http://branchandbound.net/blog/java/2017/12/automatic-module-name/
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues labels Mar 1, 2022
@saragluna saragluna added this to the Spring Cloud Azure 4.0 Beta4 milestone Mar 1, 2022
@saragluna saragluna moved this to Todo in Spring Cloud Azure Mar 1, 2022
@saragluna saragluna mentioned this issue Mar 1, 2022
Closed
@hui1110 hui1110 moved this from Todo to In Progress in Spring Cloud Azure Mar 1, 2022
@saragluna saragluna linked a pull request Mar 1, 2022 that will close this issue
Add automatic module names for Spring Cloud Azure modules #27362
Merged
@saragluna saragluna mentioned this issue Mar 1, 2022
Merged
@moarychan moarychan mentioned this issue Mar 3, 2022
Merged
@saragluna saragluna mentioned this issue Mar 4, 2022
Closed
35 tasks
@saragluna
Copy link
Member Author

Closed in #27420.

Repository owner moved this from In Progress to Done in Spring Cloud Azure Mar 4, 2022
@moarychan moarychan mentioned this issue Mar 7, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hui1110 hui1110

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta4
Development

Successfully merging a pull request may close this issue.

Add automatic module names for Spring Cloud Azure modules hui1110/azure-sdk-for-java
2 participants
@saragluna @hui1110