Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Pollable channel in Spring Integration for Event Hubs and Service Bus #26461

Closed
2 tasks
yiliuTo opened this issue Jan 13, 2022 · 2 comments
Closed
2 tasks
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@yiliuTo
Copy link
Member

yiliuTo commented Jan 13, 2022

Context

Currently the consumer model of spring integration Event Hubs/Service Bus is a reactive mode since we use the processor clients from SDK, spring integration also supports the polling mode.
Ref: KafkaMessageSource

Solution

@yiliuTo yiliuTo added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. azure-spring-eventhubs Spring event hubs related issues. labels Jan 13, 2022
@yiliuTo yiliuTo added this to the Backlog milestone Jan 13, 2022
@yiliuTo yiliuTo self-assigned this Jan 13, 2022
@saragluna saragluna added azure-spring-messaging and removed azure-spring-servicebus Spring service bus related issues. azure-spring-eventhubs Spring event hubs related issues. labels Jan 21, 2022
@yiliuTo yiliuTo moved this to Todo in Spring Cloud Azure Feb 10, 2022
@yiliuTo yiliuTo modified the milestones: Backlog, [2022] April Mar 6, 2022
@stliu stliu changed the title [FEATURE REQ] Support pollable channel for spring integration Event Hubs/Service Bus [FEATURE REQ] Pollable channel in Spring Integration for Event Hubs and Service Bus Dec 13, 2022
@sravaniv-3cortex
Copy link

sravaniv-3cortex commented Apr 2, 2023

@yiliuTo @stliu I am trying to implement Spring Cloud Data Flow Task Launcher Sink with Spring Cloud Stream Event Hubs Binder, which requires polling consumer support and EventHubsMessageChannelBinder doesn't implement createPolledConsumerResources and postProcessPollableSource methods. I found this when seeing if there is any plan to support this. I have moderate knowledge of Event Hubs but have a very basic idea of Spring Integration.

How big of an effort this would require if I want to implement this either by myself or contribute to the event hubs stream binder?
At a high level, my understanding is that we should implement the following:

  • AbstractMessageSource as mentioned in the issue description, which can use EventHubsConsumerClient (??)
  • Adding polling support to EventHubsMessageChannelBinder
  • Partitioning and acknowledging support

I considered using the AmqpMessageSource, part of Spring Integration RabbitMQ. I am unsure if Spring Integration authors would be okay refactoring that to Spring Integration Amqp support. The explanation in this issue #27052 helped a bit with the polling support understanding.

Copy link
Contributor

Hi @yiliuTo, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

No branches or pull requests

3 participants