Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unnecessary suppression in revapi.json, checkstyle-supressions.xml, spotbugs-exclude.xml #26288

Closed
chenrujun opened this issue Jan 6, 2022 · 1 comment · Fixed by #26459
Closed

Delete unnecessary suppression in revapi.json, checkstyle-supressions.xml, spotbugs-exclude.xml #26288

chenrujun opened this issue Jan 6, 2022 · 1 comment · Fixed by #26459
Assignees
@Netyyyy
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@chenrujun
Copy link

In Spring-Cloud-Azure version 4.0. A lot of code quality related suppression can be deleted.
In /eng/code-quality-reports/src/main/resources/:

  1. checkstyle/checkstyle-supressions.xml
  2. revapi/revapi.json
  3. spotbugs-exclude.xml

We need to check each item related to Spring-Cloud-Azure. Delete the item if it's not necessary more.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 6, 2022
@chenrujun chenrujun self-assigned this Jan 6, 2022
@chenrujun chenrujun added azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. labels Jan 6, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 6, 2022
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Jan 6, 2022
@chenrujun chenrujun added this to the Spring Cloud Azure 4.0 GA milestone Jan 6, 2022
@saragluna saragluna mentioned this issue Jan 6, 2022
Closed
@saragluna saragluna assigned Netyyyy and unassigned chenrujun Jan 6, 2022
@saragluna saragluna changed the title Delete unnecessary suppression in revapi.json, checkstyle-supressions.xml, spotbugs-exclude.xml. Delete unnecessary suppression in revapi.json, checkstyle-supressions.xml, spotbugs-exclude.xml. @moary Jan 6, 2022
@Netyyyy Netyyyy moved this from Todo to In Progress in Spring Cloud Azure Jan 10, 2022
@saragluna saragluna linked a pull request Jan 14, 2022 that will close this issue
Reduce Spring Coud Azure checkstyle, spotbugs and revapi configuration #26459
Merged
@saragluna
Copy link
Member

Closed in #26459.

Repository owner moved this from In Progress to Done in Spring Cloud Azure Jan 14, 2022
@saragluna saragluna mentioned this issue Jan 14, 2022
Closed
4 tasks
@saragluna saragluna changed the title Delete unnecessary suppression in revapi.json, checkstyle-supressions.xml, spotbugs-exclude.xml. @moary Delete unnecessary suppression in revapi.json, checkstyle-supressions.xml, spotbugs-exclude.xml Feb 15, 2022
@saragluna saragluna mentioned this issue Feb 15, 2022
Closed
35 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Netyyyy Netyyyy

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta3
Development

Successfully merging a pull request may close this issue.

Reduce Spring Coud Azure checkstyle, spotbugs and revapi configuration moarychan/azure-sdk-for-java
3 participants
@chenrujun @saragluna @Netyyyy