Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming problem about spring properties #25686

Closed
chenrujun opened this issue Nov 25, 2021 · 1 comment
Closed

Naming problem about spring properties #25686

chenrujun opened this issue Nov 25, 2021 · 1 comment
Assignees
@saragluna
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@chenrujun
Copy link

chenrujun commented Nov 25, 2021 •
edited
Loading

  1. Aware should not be used in these interfaces name:

azure-sdk-for-java/sdk/spring/spring-cloud-azure-core/src/main/java/com/azure/spring/core/properties/AzureProperties.java

Line 15 in ccfc66d

public interface AzureProperties extends RetryAware, ClientAware, ProxyAware, TokenCredentialAware, AzureProfileAware {

  1. CP should not be used in class name, especially out of implementation package.

azure-sdk-for-java/sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/properties/AbstractAzureAmqpCP.java

Line 15 in ccfc66d

public abstract class AbstractAzureAmqpCP extends AbstractAzureServiceCP {

@chenrujun chenrujun added the azure-spring All azure-spring related issues label Nov 25, 2021
@chenrujun chenrujun added this to the Spring Cloud Azure 4.0 GA milestone Nov 25, 2021
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 25, 2021
@chenrujun chenrujun added the Client This issue points to a problem in the data-plane of the library. label Nov 25, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 25, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 25, 2021
@saragluna saragluna mentioned this issue Dec 29, 2021
Merged
@saragluna
Copy link
Member

Closing this in #26209, the aware interface could be changed if we come up with better names.

Repository owner moved this from Todo to Done in Spring Cloud Azure Jan 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta3
Development

No branches or pull requests
2 participants
@chenrujun @saragluna