Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Cloud Azure 4.0 Refactor the health indicator of event hubs binder. #25226

Closed
Tracked by #23402
saragluna opened this issue Nov 7, 2021 · 1 comment · Fixed by #25509
Closed
Tracked by #23402

Spring Cloud Azure 4.0 Refactor the health indicator of event hubs binder. #25226

saragluna opened this issue Nov 7, 2021 · 1 comment · Fixed by #25509
Assignees
@moarychan
Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@saragluna
Copy link
Member

The current logic of health indicator for eventhub binders is not correct, it highly depends on the producer client, we should refactor this logic according to what service bus binders does.
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. labels Nov 7, 2021
@saragluna saragluna added this to the [2021] December milestone Nov 7, 2021
@saragluna saragluna self-assigned this Nov 7, 2021
@saragluna saragluna mentioned this issue Nov 7, 2021
Closed
@saragluna saragluna moved this to Todo in Spring Cloud Azure Nov 7, 2021
@chenrujun chenrujun assigned jialigit and unassigned saragluna Nov 8, 2021
@saragluna saragluna assigned moarychan and unassigned jialigit Nov 15, 2021
@moarychan moarychan moved this from Todo to In Progress in Spring Cloud Azure Nov 17, 2021
@moarychan moarychan mentioned this issue Nov 18, 2021
Merged
@moarychan moarychan linked a pull request Nov 18, 2021 that will close this issue
Refactor the eventhubs binder health indicator #25509
Merged
@moarychan moarychan moved this from In Progress to Done in Spring Cloud Azure Nov 20, 2021
@moarychan
Copy link
Member

Close now due to the PR merged.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moarychan moarychan

Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta
Development

Successfully merging a pull request may close this issue.

Refactor the eventhubs binder health indicator moarychan/azure-sdk-for-java
4 participants
@chenrujun @jialigit @moarychan @saragluna