Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate URI from CosmosProperties doesn't account for local cosmos DB emulator? #24862

Closed
Jayadeep2308 opened this issue Oct 18, 2021 · 4 comments · Fixed by #25083
Closed

Validate URI from CosmosProperties doesn't account for local cosmos DB emulator? #24862

Jayadeep2308 opened this issue Oct 18, 2021 · 4 comments · Fixed by #25083
Assignees
@backwind1233
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone
[2021] November

Comments

@Jayadeep2308
Copy link

Query/Question
As part of a Different PR (#23641), A new Method validateUri checks for regex (http[s]{0,1}://..documents.azure.com."). But cosmos local emulator DB URI is https://localhost:8081. I just wanted to check if it was intentional?
@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 18, 2021
@joshfree
Copy link
Member

@kushagraThapar could you please help @Jayadeep2308 with their question?

@Jayadeep2308
Copy link
Author

@kushagraThapar : Could you please let me know if i am missing something.

@kushagraThapar
Copy link
Member

@backwind1233 @chenrujun - can you please take a look at this issue ?

@backwind1233
Copy link
Contributor

@kushagraThapar @Jayadeep2308
I am working on a PR to change the validator, and it will be released by this month.

@backwind1233 backwind1233 linked a pull request Oct 28, 2021 that will close this issue
Update the validation logic in CosmosProperties #25083
Merged
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Oct 29, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Oct 29, 2021
@backwind1233 backwind1233 added this to the [2021] November milestone Oct 29, 2021
@backwind1233 backwind1233 self-assigned this Oct 29, 2021
@saragluna saragluna moved this to Todo in Spring Cloud Azure Apr 6, 2022
@chenrujun chenrujun moved this from Todo to Done in Spring Cloud Azure Apr 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@backwind1233 backwind1233

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Spring Cloud Azure
Archived in project
Milestone
[2021] November
Development

Successfully merging a pull request may close this issue.

Update the validation logic in CosmosProperties
4 participants
@joshfree @backwind1233 @kushagraThapar @Jayadeep2308