Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Spring libraries pick up the ENV used by azure-core/SDK. #24657

Closed
Tracked by #23402
saragluna opened this issue Oct 8, 2021 · 1 comment · Fixed by #25220
Closed
Tracked by #23402

Make sure Spring libraries pick up the ENV used by azure-core/SDK. #24657

saragluna opened this issue Oct 8, 2021 · 1 comment · Fixed by #25220
Assignees
@saragluna
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@saragluna
Copy link
Member

saragluna commented Oct 8, 2021 •
edited
Loading

There're some default env variables defined and used by azure-core and azure service clients, we'd make sure the Azure Spring libraries pick these configurations. https://azure.github.io/azure-sdk/general_azurecore.html#environment-variables
@saragluna saragluna mentioned this issue Oct 8, 2021
Closed
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 8, 2021
@saragluna saragluna changed the title Make sure to pick up the ENV used by azure-core/SDK https://azure.github.io/azure-sdk/general_azurecore.html#environment-variables. Make sure Spring libraries pick up the ENV used by azure-core/SDK. Oct 8, 2021
@saragluna saragluna self-assigned this Oct 8, 2021
@saragluna saragluna added azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. labels Oct 8, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 8, 2021
@saragluna saragluna added this to the [2021] November milestone Oct 8, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@saragluna saragluna mentioned this issue Nov 7, 2021
Merged
@saragluna saragluna linked a pull request Nov 7, 2021 that will close this issue
Spring libraries pick up the ENV used by azure-core/SDK #25220
Merged
@saragluna
Copy link
Member Author

Closed in #25220.

Repository owner moved this from Todo to Done in Spring Cloud Azure Nov 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta
Development

Successfully merging a pull request may close this issue.

Spring libraries pick up the ENV used by azure-core/SDK saragluna/azure-sdk-for-java
2 participants
@chenrujun @saragluna