Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics Advisor Readme issues #22673

Closed
v-hongli1 opened this issue Jun 30, 2021 · 2 comments
Closed

Metrics Advisor Readme issues #22673

v-hongli1 opened this issue Jun 30, 2021 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass

Comments

@v-hongli1
Copy link
Member

Section Link
image
Suggestion:
Change text to [Java Development Kit (JDK)][jdk_link] version 8 or later.

Section Link
image
Suggestion:
Add link for [grant_access]: https://docs.microsoft.com/azure/cognitive-services/authentication#assign-a-role-to-a-service-principal

Section Link
image
Reason:
Click on this link does not respond.
Suggestion:
Link change to : (#configure-an-anomaly-alert-configuration)

Section Link
image
Suggestion:
Add link for [logging]: https://github.com/Azure/azure-sdk-for-java/wiki/Logging-with-Azure-SDK

@jongio for notification.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 30, 2021
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 30, 2021
@jamar-palmer
Copy link

Hi @hongli750210 @jongio
I made the necessary changes and pushed the request.

@jamar-palmer jamar-palmer mentioned this issue Jun 30, 2021
Closed
@samvaity samvaity mentioned this issue Jun 30, 2021
Merged
@v-xuto
Copy link
Member

v-xuto commented Aug 2, 2021

Close this issue, due to PR #22694 merged.

@v-xuto v-xuto closed this as completed Aug 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@v-xuto @jamar-palmer @v-hongli1