Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Enhance metrics for Azure Spring Event Hubs #21764

Closed
Tracked by #23402 ...
saragluna opened this issue May 24, 2021 · 4 comments
Closed
Tracked by #23402 ...

[FEATURE REQ] Enhance metrics for Azure Spring Event Hubs #21764

saragluna opened this issue May 24, 2021 · 4 comments
Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@saragluna
Copy link
Member

saragluna commented May 24, 2021

Context

We plan to expose metrics for Azure Spring Event Hubs related libraries to enable developers to view metrics about connection, messages states.

Spring Event Hubs metrics components:

Prefix: eventhubs.

Metric Name Type Tag Description
connection.active Gauge eh namespace The number of active connection.
connection.opened Gauge eh namespace The number of open connection.
connection.closed Gauge eh namespace The number of closed connection.
requests Timer eh namespace Requests sent by client.
response.successes Timer eh namespace Successful responses received.
response.errors Timer eh namespace Errored responses received.
request.queue.latency Timer eh namespace Average request queue latency waiting for request to be sent to broker.
request.queue.count Timer eh namespace Number of requests in queue waiting to be sent to broker.
request.rtt Timer eh namespace Average request latency / round-trip-time to broker and back.
consumer.poll.latency Timer eh namespace The time it takes poll() to return a new message to the application.

For the SCS binder:

Prefix: spring.cloud.stream.binder.eventhubs.

Metric Name Type Tag Description
offset Gauge EventHub, ConsumerGroup Unconsumed messages for a particular group and event hub

Reference of Kafka: https://cwiki.apache.org/confluence/display/KAFKA/KIP-714:+Client+metrics+and+observability#KIP714:Clientmetricsandobservability-Clientmetricsandmetriclabels

Next Step

To support Spring Event Hubs metrics, currently we need the support from Event Hubs SDK to enable and expose metrics APIs. Tracked in #25605

@saragluna saragluna added the azure-spring All azure-spring related issues label May 24, 2021
@saragluna saragluna added the Client This issue points to a problem in the data-plane of the library. label May 24, 2021
@saragluna saragluna added this to the [2021] September milestone Jun 30, 2021
@yiliuTo yiliuTo changed the title Enhance metrics for Azure Spring messaging components Enhance metrics for Azure Spring Event Hubs Aug 6, 2021
@backwind1233 backwind1233 assigned michaelqi793 and unassigned yiliuTo Aug 6, 2021
@yiliuTo yiliuTo added azure-spring-eventhubs Spring event hubs related issues. feature-request This issue requires a new behavior in the product in order be resolved. labels Aug 10, 2021
@michaelqi793 michaelqi793 assigned yiliuTo and unassigned michaelqi793 Sep 1, 2021
@saragluna saragluna assigned ZhuXiaoBing-cn and unassigned yiliuTo Sep 2, 2021
@yiliuTo yiliuTo modified the milestones: [2021] November, Backlog Oct 11, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@saragluna saragluna modified the milestones: Backlog, [2021] December Nov 7, 2021
@saragluna
Copy link
Member Author

Link #19391

@yiliuTo yiliuTo modified the milestones: [2022] January, Backlog Nov 25, 2021
@cykl
Copy link
Contributor

cykl commented Dec 9, 2021

Hey @saragluna

How do you plan to compute offset? Will those metrics be available to non Spring users? (i.e. sdk compute metrics and Azure Spring Event Hubs bind them to Spring / Micrometer)

@saragluna
Copy link
Member Author

@cykl here's the issue used to track supporting metrics in AMQP libraries #25605.

@yiliuTo yiliuTo changed the title Enhance metrics for Azure Spring Event Hubs [FEATURE REQ] Enhance metrics for Azure Spring Event Hubs May 7, 2022
Copy link
Contributor

Hi @saragluna, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

No branches or pull requests

6 participants