Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Support Spring Cloud Stream Batch Consumer function in Spring Cloud Azure for Service Bus #21545

Closed
z1069867141 opened this issue May 17, 2021 · 6 comments
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@z1069867141
Copy link

z1069867141 commented May 17, 2021

Context

Refer to #20080

According to Spring Cloud Stream's documentation, a binder implementation may support batch consumers. Currently Azure Spring Cloud Service Bus binder does not support it.

For Kafka binder:

Goal

Support the batch-consuming function for Service Bus binder as described in the Spirng Cloud Stream documentation.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 17, 2021
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 17, 2021
@saragluna saragluna added the azure-spring-servicebus Spring service bus related issues. label May 17, 2021
@yiliuTo yiliuTo added this to the Backlog milestone Jun 1, 2021
@yiliuTo yiliuTo changed the title Support Spring Cloud Stream batch-consumers in Service Bus binders Design for Spring Cloud Stream batch-consumers in Service Bus $ Event Hub binders Jun 1, 2021
@yiliuTo yiliuTo modified the milestones: Backlog, [2021] July Jun 1, 2021
@yiliuTo yiliuTo added the azure-spring-eventhubs Spring event hubs related issues. label Jun 1, 2021
@michaelqi793
Copy link
Contributor

michaelqi793 commented Jun 10, 2021

Currently, after some codes are modified, the spring cloud stream application can work by providing a list Consumer. The following is just my draft ideas and hypothesis:
In the top-down way, there are 2 steps needed:

2, Push a batch of records as a single Spring Message into Spring framework
1, Get the batch of records from the azure-messaging-servicebus sdk

There are household chores for step 2 even though the pushing way is straightforward: Just make a list of records the payload of Spring Message, and push the Message into Spring framework by fundamentally invoking sendMessage(msg) method, because there is Json format required for the element in the list. For example, object need start with { and end with }, but string need start with " and end with ". In which layer to deal with format problem is still a question.
More efforts are needed for step 1, because azure-messaging-servicebus sdk need provide a method that returns a batch of records and properly expose it via maybe ServiceBusProcessorClient, so that azure-spring-integration-servicebus as well as the higher level azure-spring-cloud-stream can benefit from it. The question is, does the ServiceBusProcessorClient support to register a Consumer that consumes a list of ServiceBusReceivedMessageContext?

@michaelqi793
Copy link
Contributor

The draft design picture:
structure_servicebus_batchconsumer(4)
Collaborations(1)

@yiliuTo yiliuTo modified the milestones: [2021] July, [2021] August Jul 1, 2021
@yiliuTo yiliuTo changed the title Design for Spring Cloud Stream batch-consumers in Service Bus $ Event Hub binders Design for Spring Cloud Stream batch-consumers in Service Bus & Event Hub binders Jul 1, 2021
@yiliuTo yiliuTo changed the title Design for Spring Cloud Stream batch-consumers in Service Bus & Event Hub binders Design for Spring Cloud Stream batch-consumers in Service Bus Jul 1, 2021
@saragluna saragluna modified the milestones: [2021] August, Backlog Aug 4, 2021
@michaelqi793
Copy link
Contributor

#23039
#23040
#23292
#23155

@michaelqi793 michaelqi793 removed their assignment Sep 28, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@chenrujun chenrujun modified the milestones: Backlog, [2021] December Nov 8, 2021
@stliu stliu added azure-spring-copper feature-request This issue requires a new behavior in the product in order be resolved. labels Apr 2, 2022
@yiliuTo yiliuTo removed the azure-spring-eventhubs Spring event hubs related issues. label Apr 28, 2022
@yiliuTo yiliuTo changed the title Design for Spring Cloud Stream batch-consumers in Service Bus [FEATURE REQ] Design for Spring Cloud Stream batch-consumers in Service Bus May 7, 2022
@yiliuTo
Copy link
Member

yiliuTo commented May 24, 2022

The feature now is blocked due to below SDK related issues. And we need to wait for those issues get resolved for moving forward.

@stliu stliu changed the title [FEATURE REQ] Design for Spring Cloud Stream batch-consumers in Service Bus [FEATURE REQ] Support Spring Cloud Stream Batch Consumer function in Spring Cloud Azure for Service Bus Dec 12, 2022
@stliu
Copy link
Member

stliu commented Dec 12, 2022

category to spring feature parity

  1. understand the spring feature
  2. design for the implementation

Copy link
Contributor

Hi @z1069867141, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

No branches or pull requests

6 participants