Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enable client side batching for Spring Cloud Azure Service Bus #21537

Closed
z1069867141 opened this issue May 17, 2021 · 3 comments
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@z1069867141
Copy link

z1069867141 commented May 17, 2021

Context

Referring to Service Bus client-side batching, Service Bus supports client side batching operations to send messages in batches.

Goal

Support client-side batching in Spring Cloud Azure Service Bus libraries towards different spring projects.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 17, 2021
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 17, 2021
@saragluna saragluna added the azure-spring-servicebus Spring service bus related issues. label May 17, 2021
@yiliuTo yiliuTo added this to the Backlog milestone Jun 1, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@stliu
Copy link
Member

stliu commented Apr 2, 2022

@yiliuTo is this sitll valid?

@stliu stliu added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 3, 2022
@yiliuTo
Copy link
Member

yiliuTo commented Apr 6, 2022

Hi @stliu , there can be two modes of the client-side batching: explicitly and implicitly. The explicit way is to construct a batch of messages and using the SDK sender client to send directly, this is supported by ServiceBusSenderAsyncClient, however, given it has been implemented in the same as how EventHubProducerAsyncClient does, so currently we can only support batch sending in the ServiceButTemplate level, not the integration or binder level.

And for the implicit way, which is that the SDK client batches messages automatically and send, this is not supported by the ServiceBusSenderAsyncClient nor the sync client.

So I think what we can do for the client-side batching currently, is to support the batch sending API in the ServiceButTemplate level, which may bring limited benefits to the developers. Maybe we can leave it in the backlog and wait till the SDK client supports implictily batching? Or just cancel this task for there is no feature ask from the customers' side.

@yiliuTo yiliuTo changed the title Enable client side batching [Feature Request] Enable client side batching for Spring Cloud Azure Service Bus libraries Apr 28, 2022
@stliu stliu changed the title [Feature Request] Enable client side batching for Spring Cloud Azure Service Bus libraries [Feature Request] Enable client side batching for Spring Cloud Azure Service Bus Dec 13, 2022
Copy link
Contributor

Hi @z1069867141, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

No branches or pull requests

4 participants