Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode issues in core/utils/pipeline/Base64StringAdapter.java #193

Closed
jcookems opened this issue Dec 6, 2012 · 2 comments
Closed

Unicode issues in core/utils/pipeline/Base64StringAdapter.java #193

jcookems opened this issue Dec 6, 2012 · 2 comments
Milestone
0.4.2 - sprint 1

Comments

@jcookems
Copy link
Contributor

jcookems commented Dec 6, 2012

Dev estimate: 1
Test estimate: 0.5

The following code exists in Base64StringAdapter:

new String(Base64.encode(arg0))

The input for the constructor is a byte array. This is unpredictable because if no encoding is specified, the constructor uses the platform's default charset. For example, if someone sets their platform's default charset to UTF-16, even ASCII characters will be un-parseable.

In the context of the code, it appears that the data should be interpreted using UTF-8. If that is the case, then, it should be made explicit.
joostdenijs added a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
@joostdenijs
Merge pull request Azure#193 from joeg/dev
da50e50 
CloudBlob Fix: Ensure Client side exceptions are not resumed
@ghost ghost assigned gcheng Mar 6, 2013
gcheng pushed a commit to gcheng/azure-sdk-for-java that referenced this issue Mar 7, 2013
fix base64 string adapter encoding issue, issue Azure#193.
3ff10d5
@gcheng
Copy link

gcheng commented Mar 7, 2013

fix ready!

@gcheng gcheng mentioned this issue Mar 7, 2013
Merged
@jcookems
Copy link
Contributor Author

jcookems commented Mar 8, 2013

Looks good.

@jcookems jcookems closed this as completed Mar 8, 2013
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Mar 4, 2019
Merge pull request Azure#193 from Azure/master
6db9297 
5.4.0 Release
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this issue Mar 21, 2019
@jianghaolu
Annotation parser refactor (Azure#193)
856a8f6 
* Rename classes in RestProxy, inline populateMatrix() function

* Working on proxy details classes

* Rearrange v2 RestProxy classes and add tests

* Fix checkstyle errors

* Pass checkstyle. Extract HttpClient and SerializerAdapter from RestClient for RestProxy

* Updates based on pull request reviews
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this issue Apr 23, 2019
@yvgopal
Fixing a memory leak in qpid layer. (Azure#193)
e7fcc0b 
* Fixing a memory leak in qpid layer. When service force closes an idle connetion, it is not properly freed in qpid layer.
Includes some minor changes to make code simpler.

* Fixing a code review comment.
navalev pushed a commit to navalev/azure-sdk-for-java that referenced this issue Dec 24, 2019
@noelbundick
Resolve checkstyle issues (Azure#193)
717610c 
* Resolve checkstyle issues
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.2 - sprint 1
Development

No branches or pull requests
2 participants
@jcookems @gcheng