From 460ba61d5133a56bf93eebb497930a452ee71dce Mon Sep 17 00:00:00 2001 From: tadelesh Date: Thu, 20 Jan 2022 18:38:05 +0800 Subject: [PATCH] fix: empty breaking or additive items in changelog --- .../generator/autorest/model/changelog.go | 18 ++++++++++++------ .../resources/armpolicy/CHANGELOG.md | 4 ---- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/eng/tools/generator/autorest/model/changelog.go b/eng/tools/generator/autorest/model/changelog.go index 1239a4f720e4..7cdfba3b015e 100644 --- a/eng/tools/generator/autorest/model/changelog.go +++ b/eng/tools/generator/autorest/model/changelog.go @@ -83,15 +83,21 @@ func writeChangelogForPackage(r *report.Package) string { md := &markdown.Writer{} // write breaking changes - md.WriteHeader("Breaking Changes") - for _, item := range getBreakingChanges(r.BreakingChanges) { - md.WriteListItem(item) + breakings := getBreakingChanges(r.BreakingChanges) + if len(breakings) > 0 { + md.WriteHeader("Breaking Changes") + for _, item := range breakings { + md.WriteListItem(item) + } } // write additional changes - md.WriteHeader("Features Added") - for _, item := range getNewContents(r.AdditiveChanges) { - md.WriteListItem(item) + additives := getNewContents(r.AdditiveChanges) + if len(additives) > 0 { + md.WriteHeader("Features Added") + for _, item := range additives { + md.WriteListItem(item) + } } return md.String() diff --git a/sdk/resourcemanager/resources/armpolicy/CHANGELOG.md b/sdk/resourcemanager/resources/armpolicy/CHANGELOG.md index 96982acff025..0fe54b20e25d 100644 --- a/sdk/resourcemanager/resources/armpolicy/CHANGELOG.md +++ b/sdk/resourcemanager/resources/armpolicy/CHANGELOG.md @@ -18,10 +18,6 @@ - Struct `ErrorAdditionalInfo` has been removed - Struct `ErrorResponse` has been removed -### Features Added - - - ## 0.2.0 (2022-01-13) ### Breaking Changes