[service-bus] Adding in PeekMessages, DeferMessage+ReceiveDeferredMessages support #15629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2264c68 to
f040b45
Compare
added 2 commits
September 28, 2021 17:01
- Added in ReceiveDeferredMessages() - Fixing message settlement to be consistent in having a mgmt operation for each settlement method. - Adding in PeekMessages and test - Fixing bug in AMQPLinks where closing it non-permanently was...still closing it permanently. - Adding in tlsConfig configuration to make it simpler to debug at a protocol level with wireshark
b7ca288 to
e309559
Compare
added 5 commits
September 28, 2021 17:07
…y the one type definition which become completely unneeded once I made the UUID a [16]byte array.
…some error handling branches)
It could still use a refactor, but at least it documents what it does.
jhendrixMSFT
approved these changes
Sep 29, 2021
This was referenced Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in some of the critical receiver methods for deferring and retrieving deferred messages. Also, added in the track 2 compliant PeekMessages function.
There were also some bugs in how we were handling ReceiveMessages, which were found in some tests that I added.
This PR is built on top of a pending PR (#15611) so you'll want to start reviewing this code from commit 0f3d403 (my linkageddon commit) to see the relevant bits.
I've added in a temporary
replacein the go.mod file so I can pick up this fix in go-amqp that hasn't yet released: Azure/go-amqp#72).