Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests in azcore #11853

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix flaky tests in azcore #11853

merged 1 commit into from
Jul 23, 2020

Conversation

jhendrixMSFT
Copy link
Member

Includes updated dependency on internal module to fix race condition.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • Apache v2 license headers are included in each file.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@jhendrixMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jhendrixMSFT
Fix flaky tests in azcore
baa7073 
Includes updated dependency on internal module to fix race condition.
catalinaperalta
catalinaperalta approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhendrixMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@scbedd
Copy link
Member

scbedd commented Jul 23, 2020

/azp run

1 similar comment
@jhendrixMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jhendrixMSFT jhendrixMSFT merged commit 2f59e72 into Azure:master Jul 23, 2020
@jhendrixMSFT jhendrixMSFT deleted the azcore_fixtests branch July 23, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhendrixMSFT @azuresdkci @scbedd @catalinaperalta