Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones is missing in VirtualMachineScaleSetVM #2183

Closed
feiskyer opened this issue Jul 5, 2018 · 1 comment
Closed

Zones is missing in VirtualMachineScaleSetVM #2183

feiskyer opened this issue Jul 5, 2018 · 1 comment
Assignees

Comments

@feiskyer
Copy link
Member

feiskyer commented Jul 5, 2018

Zones is missing in VirtualMachineScaleSetVM. We need this to support availability zones in Kubernetes. Kubernetes is using 2017-12-01 compute api, but zones is also missing in latest 2018-04-01 version.

Zones has already been in VirtualMachineScaleSet, so we need add this also to VirtualMachineScaleSetVM.

// VirtualMachineScaleSetVM describes a virtual machine scale set virtual machine.
type VirtualMachineScaleSetVM struct {
autorest.Response `json:"-"`
// InstanceID - The virtual machine instance ID.
InstanceID *string `json:"instanceId,omitempty"`
// Sku - The virtual machine SKU.
Sku *Sku `json:"sku,omitempty"`
*VirtualMachineScaleSetVMProperties `json:"properties,omitempty"`
// Plan - Specifies information about the marketplace image used to create the virtual machine. This element is only used for marketplace images. Before you can use a marketplace image from an API, you must enable the image for programmatic use. In the Azure portal, find the marketplace image that you want to use and then click **Want to deploy programmatically, Get Started ->**. Enter any required information and then click **Save**.
Plan *Plan `json:"plan,omitempty"`
// Resources - The virtual machine child extension resources.
Resources *[]VirtualMachineExtension `json:"resources,omitempty"`
// ID - Resource Id
ID *string `json:"id,omitempty"`
// Name - Resource name
Name *string `json:"name,omitempty"`
// Type - Resource type
Type *string `json:"type,omitempty"`
// Location - Resource location
Location *string `json:"location,omitempty"`
// Tags - Resource tags
Tags map[string]*string `json:"tags"`
}

Could some one help to add this?

cc @brendandburns @khenidak
cc @joshgav @joshgav @jhendrixMSFT

@feiskyer feiskyer changed the title Zones is missing in Zones is missing in VirtualMachineScaleSetVM Jul 5, 2018
@joshgav
Copy link
Contributor

joshgav commented Jul 5, 2018

This is a bug with the compute API spec, I opened an issue in the specs repo: Azure/azure-rest-api-specs#3358 and will close this one.

@joshgav joshgav closed this as completed Jul 5, 2018
@ghost ghost removed the committed label Jul 5, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants