GET VMSS expand parameter not required

[fitzgeraldsteele]

Bug Report

• import path of package in question, e.g. .../services/compute/mgmt/2018-06-01/compute
  /services/compute/mgmt/2021-07-01/compute/virtualmachinescalesets.go#L553

• SDK version e.g. master, latest, 18.1.0
  latest
  Release v57.0.0 1630045276 (Release v57.0.0 1630045276 #15400)

  • Specify the exact commit if possible; one way to get this is the REVISION
    column output by dep status "github.com/Azure/azure-sdk-for-go.

• output of go version

• What happened?
  GET VMSS expand parameter looks like it is required. That is incorrect...it should be an optional parameter. See https://docs.microsoft.com/en-us/rest/api/compute/virtual-machine-scale-sets/get

• What did you expect or want to happen?
  Customer should be able to GET VMSS without specifying expand parameter.

• How can we reproduce it?

• Anything we should know about your environment.

[fitzgeraldsteele]

@RickWinter @lirenhe is there any way to get an RCA for this one? How is possible that an optional parameter in the API gets made as required in the SDK? Is there something we need to do differently in swagger?

[ArcturusZhang]

Hi @fitzgeraldsteele the expand is not required in the SDK, but due to some bad design in our track 1 SDK, any optional string-like parameters are generated using the type of string because it can be empty instead of using nil to represent it is empty.
We know this is not a good design, but changing this would cause massive breaking changes, therefore we will not change that in track 1 SDK (the SDKs under services directory).
If you are interested, please take a look at the track 2 SDK (the SDKs under sdk directory):

azure-sdk-for-go/sdk/compute/armcompute/zz_generated_virtualmachinescalesets_client.go

Line 471 in 3e0806d

func (client *VirtualMachineScaleSetsClient) Get(ctx context.Context, resourceGroupName string, vmScaleSetName string, options *VirtualMachineScaleSetsGetOptions) (VirtualMachineScaleSetsGetResponse, error) {

The query parameters will not "act" as if they are required like in track 1 SDKs

Since we are not able to change this in the SDK, I am going to close this issue.

[ArcturusZhang]

And BTW, in track 1 SDK, you will have to assign an empty string to it if you do not want to pass expand parameters.