Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy cleanup #15050

Closed
7 tasks
RickWinter opened this issue Jul 13, 2021 · 4 comments
Closed
7 tasks

Policy cleanup #15050

RickWinter opened this issue Jul 13, 2021 · 4 comments
Assignees
@jhendrixMSFT
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2021] September

Comments

@RickWinter
Copy link
Member

Feature Request

Move policies into a module

  • TokenRequestOptions is “Options” the right thing to call this
  • AuthenticationPolicyOptions
    • Field name may need to change
    • Possibly get rid of one of them
  • Policies might be able to be in a modules
  • Pipeline could perhaps be in SDK packages
  • Check RetryOptions for name patterns
@RickWinter RickWinter added Client This issue points to a problem in the data-plane of the library. Azure.Core feature-request This issue requires a new behavior in the product in order be resolved. labels Jul 13, 2021
@seankane-msft
Copy link
Member

Rename Options here to TokenRequest

@seankane-msft
Copy link
Member

AuthenticationPolicyOptions -> AuthenticationOptions

@seankane-msft
Copy link
Member

Change this to NewAuthenticationPolicy

@seankane-msft seankane-msft added the blocking-release Blocks release label Aug 9, 2021
@RickWinter RickWinter added this to the [2021] September milestone Aug 9, 2021
@jhendrixMSFT jhendrixMSFT self-assigned this Aug 16, 2021
@jhendrixMSFT jhendrixMSFT mentioned this issue Aug 20, 2021
Merged
5 tasks
@jhendrixMSFT
Copy link
Member

Fixed in v0.19.0

@RickWinter RickWinter removed the blocking-release Blocks release label Sep 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] September
Development

No branches or pull requests
3 participants
@RickWinter @jhendrixMSFT @seankane-msft