Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention min clang format version and format all cpp and hpp files with clang-format version 9.0 #1208

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Mention min clang format version and format all cpp and hpp files with clang-format version 9.0 #1208

merged 3 commits into from
Dec 18, 2020

Conversation

vhvb1989
Copy link
Member

fixes: #1207

@vhvb1989 vhvb1989 self-assigned this Dec 18, 2020
@vhvb1989 vhvb1989 added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Dec 18, 2020
@vhvb1989 vhvb1989 added this to the MQ-2020 milestone Dec 18, 2020
@vhvb1989 vhvb1989 requested a review from Jinming-Hu December 18, 2020 01:20
@vhvb1989 vhvb1989 changed the title Mention min clang format version Mention min clang format version and format all cpp and hpp files with clang-format version 9.0 Dec 18, 2020
@vhvb1989 vhvb1989 force-pushed the mention-min-clang-format-version branch from d942340 to 0ab3b7f Compare December 18, 2020 01:27
ahsonkhan
ahsonkhan approved these changes Dec 18, 2020
View reviewed changes
sdk/storage/azure-storage-common/src/crypt.cpp
#include "azure/storage/common/crypt.hpp"

#if defined(AZ_PLATFORM_WINDOWS)
#if !defined(NOMINMAX)
#define NOMINMAX
#endif
// Windows needs to go before bcrypt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #1209

@vhvb1989 vhvb1989 merged commit 8aac909 into Azure:master Dec 18, 2020
@vhvb1989 vhvb1989 deleted the mention-min-clang-format-version branch December 18, 2020 02:34
@ahsonkhan ahsonkhan mentioned this pull request Dec 18, 2020
Closed
@Jinming-Hu
Copy link
Member

Jinming-Hu commented Dec 18, 2020 •
edited
Loading

Storage team has a major concern about you making ~300 lines of code change into storage sdk, and merging it without storage team's approval. We'd appreciate if you can wait for our approval before merging it. Or instead, you could also change core sdk only code, and open an issue for us, we'll make the same change in storage code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

@Jinming-Hu Jinming-Hu Jinming-Hu left review comments

@antkmsft antkmsft Awaiting requested review from antkmsft

@danieljurek danieljurek Awaiting requested review from danieljurek

@katmsft katmsft Awaiting requested review from katmsft

@RickWinter RickWinter Awaiting requested review from RickWinter

@schaabs schaabs Awaiting requested review from schaabs

@vinjiang vinjiang Awaiting requested review from vinjiang

Assignees

@vhvb1989 vhvb1989

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
MQ-2020
3 participants
@vhvb1989 @Jinming-Hu @ahsonkhan