Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we need OpenSSL >= 3.0.2, say so instead of 1.1.1n #3703

Closed
antkmsft opened this issue Jun 3, 2022 · 4 comments · Fixed by #3705
Closed

If we need OpenSSL >= 3.0.2, say so instead of 1.1.1n #3703

antkmsft opened this issue Jun 3, 2022 · 4 comments · Fixed by #3705
Assignees
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@antkmsft
Copy link
Member

antkmsft commented Jun 3, 2022

"[W]e're at OpenSSL 3.0.2, I believe, not 1.1.1n."

Originally posted by @LarryOsterman in #3701 (comment)

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 3, 2022
@antkmsft
Copy link
Member Author

antkmsft commented Jun 3, 2022

@LarryOsterman Would you mind to check if we do require min version of 3.0.2, and update all occurrences of "1.1.1n" (there might be more than in this PR), or in general if there is ever a dependency on openssl without min version specification, also put it there?

@LarryOsterman
Copy link
Member

We shouldn't have any version dependencies in packages unless we have a strict requirement that a package be greater than a particular value. Otherwise we should let the vcpkg base line determine the package.

For instance, we require OpenTelemetry 1.3.0 (because we require a bug fix which is only available in OpenTelemetry 1.3.0). But we don't have such a requirement for OpenSSL, just that we have the most recent version in teh vcpkg baseline.

@antkmsft
Copy link
Member Author

antkmsft commented Jun 3, 2022

So, should we drop all "version>=" for OpenSSL then?
I think you added the "version>=", and you're the biggest OpenSSL user, can you remove it?

@LarryOsterman LarryOsterman self-assigned this Jun 3, 2022
@LarryOsterman
Copy link
Member

I have the fix ready for my next PR

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants