Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a contributor, I want to know the minimun version from clang-format that I need to set to avoid introducing a different format when doing auto-formatting #1207

Closed
vhvb1989 opened this issue Dec 18, 2020 · 0 comments · Fixed by #1208
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@vhvb1989
Copy link
Member

vhvb1989 commented Dec 18, 2020

When installing clang-format on Linux Ubuntu 18.05 by default we get:
clang-format version 6.0.0-1ubuntu2

This version behaves different while formating some specific thigs like:

    explicit Request(HttpMethod httpMethod, Url url, bool downloadViaStream)
        : Request(
              httpMethod,
              std::move(url),
              NullBodyStream::GetNullBodyStream(),
              downloadViaStream)
    {
    }

For newer version of clang-format and the latest version that comes with Visual Studio, we get some spaces removed in the above example
image

Note: For ubuntu 20, the default clang-format version is 10.0

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 18, 2020
@vhvb1989 vhvb1989 self-assigned this Dec 18, 2020
@vhvb1989 vhvb1989 added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Dec 18, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 18, 2020
@vhvb1989 vhvb1989 added this to the MQ-2020 milestone Dec 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
1 participant