Mention min clang format version and format all cpp and hpp files wit…

…h clang-format version 9.0 (#1208)

* Add info about clang-format version

* updates for cpp and hpp format

* special cases

CONTRIBUTING.md

@@ -57,6 +57,7 @@ CMake version 3.13 or higher is required to build these libraries. Download and
 #### Third Party Dependencies
 - curl
 - libxml2
+- clang-format (min version 9)
 
 Vcpkg can be used to install the Azure SDK for CPP dependencies into a specific folder on the system instead of globally installing them.
 Follow [vcpkg install guide](https://github.com/microsoft/vcpkg#getting-started) to get vcpkg and install the following dependencies:

sdk/core/azure-core/inc/azure/core/http/http.hpp

@@ -508,10 +508,10 @@ namespace Azure { namespace Core { namespace Http {
      */
     explicit Request(HttpMethod httpMethod, Url url, bool downloadViaStream)
         : Request(
-              httpMethod,
-              std::move(url),
-              NullBodyStream::GetNullBodyStream(),
-              downloadViaStream)
+            httpMethod,
+            std::move(url),
+            NullBodyStream::GetNullBodyStream(),
+            downloadViaStream)
     {
     }
 

sdk/core/azure-core/inc/azure/core/nullable.hpp

@@ -48,7 +48,9 @@ namespace Azure { namespace Core {
      * @param initialValue A non-absent value to initialize with.
      */
     constexpr Nullable(T initialValue) noexcept(std::is_nothrow_move_constructible<T>::value)
-        : m_value(std::move(initialValue)), m_hasValue(true) {}
+        : m_value(std::move(initialValue)), m_hasValue(true)
+    {
+    }
 
     /// Copy constructor.
     Nullable(const Nullable& other) noexcept(std::is_nothrow_copy_constructible<T>::value)

sdk/core/azure-core/inc/azure/core/response.hpp

@@ -57,44 +57,35 @@ namespace Azure { namespace Core {
      *
      * @return `true` If a value is contained, `false` if value is absent.
      */
-    bool HasValue() const noexcept {
-      return this->m_value.HasValue();
-    }
+    bool HasValue() const noexcept { return this->m_value.HasValue(); }
 
     /**
      * @brief Get a pointer to a value of a specific type.
      */
-    const T* operator->() const {
+    const T* operator->() const
+    {
       return &this->m_value.GetValue(); // GetValue ensures there is a contained value
     }
 
     /**
      * @brief Get a pointer to a value of a specific type.
      */
-    T* operator->() {
-      return &this->m_value.GetValue();
-    }
+    T* operator->() { return &this->m_value.GetValue(); }
 
     /**
      * @brief Get value of a specific type.
      */
-    T& operator*() {
-      return this->m_value.GetValue();
-    }
+    T& operator*() { return this->m_value.GetValue(); }
 
     /**
      * @brief Get value of a specific type.
      */
-    const T& operator*() const {
-      return this->m_value.GetValue();
-    }
+    const T& operator*() const { return this->m_value.GetValue(); }
 
     /**
      * @brief Get an rvalue reference to the value of a specific type.
      */
-    T&& ExtractValue() {
-      return std::move(this->m_value).GetValue();
-    }
+    T&& ExtractValue() { return std::move(this->m_value).GetValue(); }
 
     /**
      * @brief Get a smart pointer rvalue reference to the value of a specific type.

sdk/core/azure-core/inc/azure/core/version.hpp

@@ -52,4 +52,3 @@ namespace Azure { namespace Core {
 #undef AZURE_CORE_VERSION_MINOR
 #undef AZURE_CORE_VERSION_PATCH
 #undef AZURE_CORE_VERSION_PRERELEASE
-

sdk/core/azure-core/src/http/curl/curl.cpp

@@ -341,13 +341,11 @@ CURLcode CurlConnection::SendBuffer(
 
       switch (sendResult)
       {
-        case CURLE_OK:
-        {
+        case CURLE_OK: {
           sentBytesTotal += sentBytesPerRequest;
           break;
         }
-        case CURLE_AGAIN:
-        {
+        case CURLE_AGAIN: {
           // start polling operation with 1 min timeout
           auto pollUntilSocketIsReady = pollSocketUntilEventOrTimeout(
               context, m_curlSocket, PollSocketDirection::Write, 60000L);
@@ -364,8 +362,7 @@ CURLcode CurlConnection::SendBuffer(
           // Ready to continue download.
           break;
         }
-        default:
-        {
+        default: {
           return sendResult;
         }
       }
@@ -721,8 +718,7 @@ int64_t CurlConnection::ReadFromSocket(Context const& context, uint8_t* buffer,
 
     switch (readResult)
     {
-      case CURLE_AGAIN:
-      {
+      case CURLE_AGAIN: {
         // start polling operation
         auto pollUntilSocketIsReady = pollSocketUntilEventOrTimeout(
             context, m_curlSocket, PollSocketDirection::Read, 60000L);
@@ -739,12 +735,10 @@ int64_t CurlConnection::ReadFromSocket(Context const& context, uint8_t* buffer,
         // Ready to continue download.
         break;
       }
-      case CURLE_OK:
-      {
+      case CURLE_OK: {
         break;
       }
-      default:
-      {
+      default: {
         // Error reading from socket
         throw TransportException(
             "Error while reading from network socket. CURLE code: " + std::to_string(readResult)

sdk/core/azure-core/test/e2e/azure_core_with_curl_bodyStream.cpp

@@ -165,7 +165,7 @@ void printStream(Context const& context, std::unique_ptr<Http::RawResponse> resp
   }
 
   cout << static_cast<typename std::underlying_type<Http::HttpStatusCode>::type>(
-              response->GetStatusCode())
+      response->GetStatusCode())
        << endl;
   cout << response->GetReasonPhrase() << endl;
   cout << "headers:" << endl;

sdk/core/azure-core/test/ut/logging.cpp

@@ -1,10 +1,10 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include <gtest/gtest.h>
 #include <azure/core/http/pipeline.hpp>
 #include <azure/core/internal/log.hpp>
 #include <azure/core/logging/logging.hpp>
+#include <gtest/gtest.h>
 
 #include <utility>
 #include <vector>

sdk/core/azure-core/test/ut/nullable.cpp

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include <gtest/gtest.h>
 #include <azure/core/nullable.hpp>
+#include <gtest/gtest.h>
 #include <string>
 #include <vector>
 
@@ -123,36 +123,35 @@ TEST(Nullable, Swap)
 
 TEST(Nullable, CopyConstruction)
 {
-  //Empty
+  // Empty
   Nullable<int> val1;
   Nullable<int> val2(val1);
   EXPECT_FALSE(val1);
   EXPECT_FALSE(val2);
 
-  //Non-Empty
+  // Non-Empty
   Nullable<int> val3(12345);
   Nullable<int> val4(val3);
   EXPECT_TRUE(val3);
   EXPECT_TRUE(val4);
   EXPECT_TRUE(val3.GetValue() == 12345);
   EXPECT_TRUE(val4.GetValue() == 12345);
 
-  //Literal
+  // Literal
   Nullable<int> val5 = 54321;
   EXPECT_TRUE(val5);
   EXPECT_TRUE(val5.GetValue() == 54321);
 
-  //Value
+  // Value
   const int i = 1;
   Nullable<int> val6(i);
   EXPECT_TRUE(val6);
   EXPECT_TRUE(val6.GetValue() == 1);
-
 }
 
 TEST(Nullable, Disengage)
 {
-  Nullable<int> val1(12345);  
+  Nullable<int> val1(12345);
   val1.Reset();
   EXPECT_FALSE(val1);
 }
@@ -170,7 +169,5 @@ TEST(Nullable, ValueOr)
   EXPECT_FALSE(val2);
   EXPECT_TRUE(val2.ValueOr(678910) == 678910);
   // Ensure val2 is still disengaged after call to ValueOr
-  EXPECT_FALSE(val2);  
-
+  EXPECT_FALSE(val2);
 }
-

sdk/core/azure-core/test/ut/operation.cpp

@@ -23,7 +23,7 @@ TEST(Operation, Poll)
   EXPECT_FALSE(operation.IsDone());
   EXPECT_FALSE(operation.HasValue());
 
-  while(!operation.IsDone())
+  while (!operation.IsDone())
   {
     EXPECT_FALSE(operation.HasValue());
     EXPECT_THROW(operation.Value(), std::runtime_error);
@@ -45,12 +45,12 @@ TEST(Operation, PollUntilDone)
   EXPECT_FALSE(operation.IsDone());
   EXPECT_FALSE(operation.HasValue());
   EXPECT_THROW(operation.Value(), std::runtime_error);
-  
+
   auto start = std::chrono::high_resolution_clock::now();
   auto response = operation.PollUntilDone(500ms);
   auto end = std::chrono::high_resolution_clock::now();
   std::chrono::duration<double, std::milli> elapsed = end - start;
-  //StringOperation test code is implemented to poll 2 times
+  // StringOperation test code is implemented to poll 2 times
   EXPECT_TRUE(elapsed >= 1s);
 
   EXPECT_TRUE(operation.IsDone());

sdk/core/azure-core/test/ut/pipeline.cpp

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include <gtest/gtest.h>
 #include <azure/core/http/pipeline.hpp>
 #include <azure/core/http/policy.hpp>
+#include <gtest/gtest.h>
 
 #include <vector>
 

sdk/core/azure-core/test/ut/policy.cpp

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include <gtest/gtest.h>
 #include <azure/core/http/pipeline.hpp>
 #include <azure/core/http/policy.hpp>
+#include <gtest/gtest.h>
 
 #include <vector>
 

sdk/core/azure-core/test/ut/simplified_header.cpp

@@ -8,8 +8,8 @@
  *
  */
 
-#include <gtest/gtest.h>
 #include <azure/core.hpp>
+#include <gtest/gtest.h>
 
 #include <vector>
 

sdk/core/azure-core/test/ut/telemetry_policy.cpp

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include <gtest/gtest.h>
 #include <azure/core/http/pipeline.hpp>
 #include <azure/core/http/policy.hpp>
+#include <gtest/gtest.h>
 
 using namespace Azure::Core;
 using namespace Azure::Core::Http;

sdk/core/azure-core/test/ut/transport_adapter_base.hpp

@@ -9,10 +9,10 @@
  *
  */
 
-#include <gtest/gtest.h>
 #include <azure/core/http/body_stream.hpp>
 #include <azure/core/http/http.hpp>
 #include <azure/core/http/pipeline.hpp>
+#include <gtest/gtest.h>
 
 #include <memory>
 #include <vector>

sdk/core/azure-core/test/ut/uuid.cpp

@@ -1,10 +1,10 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include <gtest/gtest.h>
 #include <azure/core/uuid.hpp>
-#include <string>
+#include <gtest/gtest.h>
 #include <set>
+#include <string>
 
 using namespace Azure::Core;
 
@@ -14,14 +14,14 @@ TEST(Uuid, Basic)
   EXPECT_TRUE(uuid.GetUuidString().length() == 36);
 }
 
-TEST(Uuid, Randomness) 
-{ 
+TEST(Uuid, Randomness)
+{
   const int size = 100000;
   std::set<std::string> uuids;
   for (int i = 0; i < size; i++)
   {
     auto ret = uuids.insert(Uuid::CreateUuid().GetUuidString());
-    //If the value already exists in the set then the insert will fail
+    // If the value already exists in the set then the insert will fail
     // ret.second == false means the insert failed.
     EXPECT_TRUE(ret.second);
   }

sdk/identity/azure-identity/inc/azure/identity/version.hpp

@@ -52,4 +52,3 @@ namespace Azure { namespace Identity {
 #undef AZURE_IDENTITY_VERSION_MINOR
 #undef AZURE_IDENTITY_VERSION_PATCH
 #undef AZURE_IDENTITY_VERSION_PRERELEASE
-