Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description for requireGuestProvisionSignal. #9962

Merged
merged 1 commit into from
Jul 1, 2020
+1 −1
Merged

Update description for requireGuestProvisionSignal. #9962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8514,7 +8514,7 @@
},
"requireGuestProvisionSignal": {
"type": "boolean",
"description": "Specifies whether the guest provision signal is required to infer provision success of the virtual machine."
"description": "Specifies whether the guest provision signal is required to infer provision success of the virtual machine. **Note: This property is for private testing only, and all customers must not set the property to false.**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the customer set this to true or not set it at all? If this parameter has to be set to a value, seems like this should say 'all customers must set this property to true.'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customer should set it to true or should not give requireGuestProvisionSignal at all. @Drewm3 can confirm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more clear to say that all customers must set it to true when used, but it's not a blocking concern so I'll sign off.

}
},
"description": "Specifies the operating system settings for the virtual machine. Some of the settings cannot be changed once VM is provisioned."
Expand Down