-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DeletionRecovery Level #9895
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L3875:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L3875:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L5900:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L5768:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L4242:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L4176:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L4155:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L4122:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L3875:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L3875:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L4155:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L4122:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L5900:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L5768:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L5592:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L5493:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L5592:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L5493:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'CustomizedRecoverable+Purgeable, CustomizedRecoverable, CustomizedRecoverable+ProtectedSubscription' from the old version. New: Microsoft.KeyVault/stable/7.0/keyvault.json#L4242:9 Old: Microsoft.KeyVault/stable/7.0/keyvault.json#L4176:9 |
️❌
LintDiff: 2 Errors, 0 Warnings [Detail] [Expand]
❌
Rule | Message |
---|---|
An error occurred while executing JSON.parse() on the linter output for specification/keyvault/data-plane/readme.md: |
"role":"Lint Diff", "new":"https://github.com/Azure/azure-rest-api-specs/blob/b6f52e28b6b61e30043038aa292d5ade0c5d077e/specification/keyvault/data-plane/readme.md", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/keyvault/data-plane/readme.md" |
An error occurred while executing JSON.parse() on the linter output for specification/keyvault/data-plane/readme.md: |
"role":"Lint Diff", "new":"https://github.com/Azure/azure-rest-api-specs/blob/b6f52e28b6b61e30043038aa292d5ade0c5d077e/specification/keyvault/data-plane/readme.md", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/keyvault/data-plane/readme.md" |
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
Please #hold-off it is still a draft |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
"values": [ | ||
{ | ||
"value": "Purgeable", | ||
"description": "It can be purged by a priviliged user after 90 days" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: these are sentences used in documentation and should use punctuation, i.e. end in a period.
}, | ||
{ | ||
"value": "Recoverable+Purgeable", | ||
"description": "It can be recovered by a priviliged user until is purged.It can be purged by a priviliged user after 90 days" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space between "purged.It".
}, | ||
{ | ||
"value": "Recoverable+ProtectedSubscription", | ||
"description": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing description.
}, | ||
{ | ||
"value": "CustomizedRecoverable", | ||
"description": "It can be recovered by priviliged user until is purged. System purge after number of days specificed in 'softDeleteRetentionInDays'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a privileged user"
"values": [ | ||
{ | ||
"value": "Purgeable", | ||
"description": "It can be purged by a priviliged user after 90 days" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"privileged" (last "i" -> "e"). If you're using Visual Studio Code, I highly recommend the cSpell and Micorosft Docs extensions (the latter is an extension pack).
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
No commit pushedDate could be found for PR 9895 in repo Azure/azure-rest-api-specs |
#sign-off |
#sign-off |
Azure Pipelines successfully started running 1 pipeline(s). |
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (22 commits) Update DeletionRecovery Level (Azure#9895) Updating operations API to enable metrics via public metrics REST API. (Azure#9918) Xynoclafe/2020 06 version (Azure#9888) update java md (Azure#9923) Compute 2020-06-01 API version (Azure#9167) Merge Dev containerservice microsoft.container service 2020 06 01 (Azure#9914) new Batch Document Translation API Preview 1.0 (Azure#9218) 1. Add a property as required (Azure#9899) Operational insights delete wrong lines data export (Azure#9849) [SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 (Azure#9831) [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 (Azure#9838) add Java to AVS (Azure#9855) LaMigrationDate (Azure#9882) change vmware client name to AVSClient (Azure#9863) Fix typo in common private links definition for actionsRequired (Azure#9727) Microsoft.Support RP documentation updates (Azure#9880) BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… (Azure#9868) Update ci-fix.md (Azure#9881) Update Attestation control plane swagger to include 2 new defaultprovider API (Azure#9819) update java readme digitaltwins (Azure#9878) ...
* Update description for certificate type * update description for certificate type * Revert "update description for certificate type" This reverts commit 3093d69. * Revert "Update description for certificate type" This reverts commit 83c4922. * Update description for certificate type * Update * Update DeletionRecoveryLevel * Update keyvault.json * Update RecoveryLevel * Update Recovery Level description * Update Deletion Recovery Level
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.