Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMS] Adding New LVA Edge Swagger file to azure media services data p… #9697

Merged
merged 13 commits into from
Jun 29, 2020
Merged

[AMS] Adding New LVA Edge Swagger file to azure media services data p… #9697

merged 13 commits into from
Jun 29, 2020

Conversation

giakas
Copy link
Contributor

@giakas giakas commented Jun 3, 2020 •
edited
Loading

…lane

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 3, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 3, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 5ec9cef with merge commit 43a8b2b. SDK Automation 13.0.17.20200619.4 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Azure.Media.LiveVideoAnalytics.Edge [View full logs]  [Release SDK Changes] 
      Error: spawn bundle ENOENT
Error: spawn rake ENOENT

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 3, 2020 •
    edited
    Loading

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 3, 2020 •
    edited
    Loading

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 3, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 3, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 3, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 3, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    This was referenced Jun 3, 2020
    Open
    Closed
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @giakas giakas requested a review from allenjzhang June 3, 2020 19:26
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @giakas giakas added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Jun 22, 2020
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 22, 2020 •
    edited
    Loading

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @azure-pipelines
    Copy link

    No commit pushedDate could be found for PR 9697 in repo Azure/azure-rest-api-specs

    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @giakas giakas added ReadyForSDKReview and removed NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR labels Jun 23, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @giakas giakas mentioned this pull request Jun 25, 2020
    Closed
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jun 29, 2020
    Closed
    @tjprescott
    Copy link
    Member

    @giakas is this ready to merge?

    @tjprescott tjprescott merged commit 43a8b2b into Azure:master Jun 29, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @giakas @00Kai0
    [AMS] Adding New LVA Edge Swagger file to azure media services data p… (
    548917e 
    Azure#9697)

* [AMS] Adding New LVA Edge Swagger file to azure media services data plane

* fix prettier issues

* fix go SDK folder structure

* change open-api type to data-plane

* Update LVA swagger files with validation errors.

* Fix Prettier and spell checks

* Rename folder Microsoft.LVAEdge to LvaEdge

* fix a casing in the name

* updateing some namespaces.

* removing all other language support other than C#

* fix some strings

* Update c# namespace to Azure.Media.LiveVideoAnalytics.Edge
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @tjprescott tjprescott tjprescott approved these changes

    @allenjzhang allenjzhang Awaiting requested review from allenjzhang

    Assignees

    @tjprescott tjprescott

    Labels
    ReadyForSDKReview
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @giakas @azuresdkci @tjprescott