Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2020-02-14 #9297

Merged
merged 4 commits into from
May 4, 2020
Merged

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2020-02-14 #9297

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9443737
Make identity field a required field for image template resource
Apr 30, 2020
e6e0773
Update examples to include identity in requests/responses
Apr 30, 2020
1873b73
Update to have POST /run & /cancel to return 200 code for powershell …
May 4, 2020
a875453
Update description of 200 code
May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CancelImageBuild.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"api-version": "2020-02-14"
},
"responses": {
"200": {},
"204": {},
"202": {
"headers": {
Expand Down
24 changes: 24 additions & 0 deletions ...r/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CreateImageTemplateLinux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
"imagetemplate_tag1": "IT_T1",
"imagetemplate_tag2": "IT_T2"
},
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down Expand Up @@ -50,6 +56,15 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down Expand Up @@ -89,6 +104,15 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down
24 changes: 24 additions & 0 deletions ...Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CreateImageTemplateWindows.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
"imagetemplate_tag1": "IT_T1",
"imagetemplate_tag2": "IT_T2"
},
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down Expand Up @@ -79,6 +85,15 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down Expand Up @@ -118,6 +133,15 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down
141 changes: 0 additions & 141 deletions ...MachineImages/stable/2020-02-14/examples/CreateImageTemplateWithUserAssignedIdentity.json
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions ...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/GetImageTemplate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down
18 changes: 18 additions & 0 deletions ...manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/ListImageTemplates.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down Expand Up @@ -46,6 +55,15 @@
"name": "mySecondImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "PlatformImage",
Expand Down
18 changes: 18 additions & 0 deletions ...ger/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/ListImageTemplatesByRg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down Expand Up @@ -47,6 +56,15 @@
"name": "myOtherImageTemplate",
"location": "eastus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "PlatformImage",
Expand Down
3 changes: 2 additions & 1 deletion ...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/RunImageTemplate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/{location}/operations/{operation-id}?api-version=2020-02-14"
}
},
"204": {}
"204": {},
"200": {}
}
}
9 changes: 9 additions & 0 deletions ...er/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/UpdateImageTemplateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@
"tags": {
"new-tag": "new-value"
},
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
Expand Down
12 changes: 9 additions & 3 deletions ...ilder/resource-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/imagebuilder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,6 @@
},
"Create an Image Template for Windows.": {
"$ref": "./examples/CreateImageTemplateWindows.json"
},
"Create an Image Template with a user assigned identity configured": {
"$ref": "./examples/CreateImageTemplateWithUserAssignedIdentity.json"
}
}
},
Expand Down Expand Up @@ -350,6 +347,9 @@
}
],
"responses": {
"200": {
"description": "The retrieval of the operation was successful."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Either "The operation was successful" Or more specific "The Run Operation was successful"

},
"204": {
"description": "The operation was successful."
},
Expand Down Expand Up @@ -396,6 +396,9 @@
}
],
"responses": {
"200": {
"description": "The retrieval of the operation was successful."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Either "The operation was successful" Or more specific "The Cancel Operation was successful."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. thx

},
"204": {
"description": "The long running image build has been canceled."
},
Expand Down Expand Up @@ -1162,6 +1165,9 @@
{
"$ref": "#/definitions/Resource"
}
],
"required": [
"identity"
]
},
"ImageTemplateUpdateParameters": {
Expand Down