ThreatIntel whitelisting for firewall policy #9224

saisujithreddym · 2020-04-25T21:43:39Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-04-25T21:43:55Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-25T21:45:07Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 130fea7 with merge commit 956f6ebade4073bb1f2521b5aadd98f781d55d49. SDK Automation 13.0.17.20200424.4
️✔️@azure/arm-network [Logs] [Preview SDK Changes]
- azure-arm-network-21.0.0.tgz

openapi-sdkautomation · 2020-04-25T21:45:08Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 130fea7 with merge commit 956f6ebade4073bb1f2521b5aadd98f781d55d49. SDK Automation 13.0.17.20200424.4
⚠️network/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-03-30 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-12-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-09-01 [Logs]
```
No file is changed.
```

⚠️network/mgmt/2019-11-01 [Logs]

SDK Repository Package Error: Error: git push --set-upstream integration sdkAutomation/network_mgmt_2019-11-01 --force fatal: unable to access 'https://x-access-token:v1.a85b3f4afe4b1dcf17be010365d43a65e8e2a3a1@github.com/AzureSDKAutomation/azure-sdk-for-go/': Failed to connect to github.com port 443: Connection timed out
, {}
No file is changed.

⚠️network/mgmt/2019-12-01 [Logs]
```
No file is changed.
```
⚠️preview/network/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-04-25T21:45:10Z

azure-sdk-for-net

❌ failed [Logs] [Expand Details]

❌ Generate from 130fea7 with merge commit 956f6ebade4073bb1f2521b5aadd98f781d55d49. SDK Automation 13.0.17.20200424.4

SDK Repository Error: {
  "name": "HttpError",
  "status": 401,
  "headers": {
    "access-control-allow-origin": "*",
    "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset",
    "connection": "close",
    "content-length": "83",
    "content-security-policy": "default-src 'none'",
    "content-type": "application/json; charset=utf-8",
    "date": "Mon, 27 Apr 2020 17:44:32 GMT",
    "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
    "server": "GitHub.com",
    "status": "401 Unauthorized",
    "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
    "vary": "Accept-Encoding, Accept, X-Requested-With",
    "x-content-type-options": "nosniff",
    "x-frame-options": "deny",
    "x-github-media-type": "github.machine-man-preview; format=json, github.machine-man-preview; format=json",
    "x-github-request-id": "0406:3AF9:1578B67:2F977F9:5EA71A00",
    "x-ratelimit-limit": "60",
    "x-ratelimit-remaining": "59",
    "x-ratelimit-reset": "1588013072",
    "x-xss-protection": "1; mode=block"
  },
  "request": {
    "method": "GET",
    "url": "https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-net/git/refs/heads/",
    "headers": {
      "accept": "application/vnd.github.machine-man-preview+json,application/vnd.github.machine-man-preview+json",
      "user-agent": "octokit.js/16.43.1 Node.js/12.16.2 (Linux 5.0; x64)",
      "authorization": "token [REDACTED]"
    },
    "request": {}
  },
  "documentation_url": "https://developer.github.com/v3"
}
HttpError: Bad credentials
    at /z/node_modules/@octokit/request/dist-node/index.js:66:23
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

openapi-sdkautomation · 2020-04-25T21:45:10Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-25T21:45:11Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 130fea7 with merge commit 956f6ebade4073bb1f2521b5aadd98f781d55d49. SDK Automation 13.0.17.20200424.4
⚠️sdk/network/mgmt-v2019_02_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_04_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_06_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_07_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_08_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_09_01 [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-04-25T21:45:12Z

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 130fea7 with merge commit 956f6ebade4073bb1f2521b5aadd98f781d55d49. SDK Automation 13.0.17.20200424.4
```
Failed to find any diff after autorest so no changed packages was found.
```

azure-pipelines · 2020-04-25T21:53:35Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-04-25T21:55:32Z

Can one of the admins verify this patch?

azure-pipelines · 2020-04-25T22:34:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-25T22:52:16Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-25T23:01:04Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-25T23:11:02Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-25T23:11:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-25T23:20:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-26T03:18:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-27T17:42:54Z

Azure Pipelines successfully started running 1 pipeline(s).

saisujithreddym · 2020-04-29T18:39:28Z

Combined this PR with #9271. Closing this.

TI whitelisting for firewall policy

efde747

saisujithreddym requested review from MikhailTryakhov, anton-evseev and v-shhatt as code owners April 25, 2020 21:43

openapi-assignment-bot bot assigned mmyyrroonn Apr 25, 2020

running prettier

9f8e895

openapi-sdkautomation bot mentioned this pull request Apr 25, 2020

[AutoPR @azure/arm-network] ThreatIntel whitelisting for firewall policy AzureSDKAutomation/azure-sdk-for-js#1133

Open

fixing description

a9cde25

removing extra property from the response

b4b0ed9

adding the new property in examples

84fdda1

openapi-sdkautomation bot mentioned this pull request Apr 26, 2020

[AutoPR Microsoft.Azure.Management.Network] ThreatIntel whitelisting for firewall policy AzureSDKAutomation/azure-sdk-for-net#982

Open

mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 26, 2020

mmyyrroonn approved these changes Apr 26, 2020

View reviewed changes

retrigger the pr check

110561c

saisujithreddym requested a review from mmyyrroonn April 26, 2020 03:20

clean up

130fea7

anton-evseev approved these changes Apr 27, 2020

View reviewed changes

saisujithreddym changed the title ~~ThreatIntel whitelisting for firewall policy~~ ThreatIntel whitelisting for firewall policy [DO NOT MERGE] Apr 29, 2020

saisujithreddym changed the title ~~ThreatIntel whitelisting for firewall policy [DO NOT MERGE]~~ ThreatIntel whitelisting for firewall policy Apr 29, 2020

saisujithreddym mentioned this pull request Apr 29, 2020

Revert https://github.com/Azure/azure-rest-api-specs/pull/9045 + Add TI Whitelist #9271

Merged

5 tasks

saisujithreddym closed this Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ThreatIntel whitelisting for firewall policy #9224

ThreatIntel whitelisting for firewall policy #9224

saisujithreddym commented Apr 25, 2020 •

edited by mmyyrroonn

Loading

azure-pipelines bot commented Apr 25, 2020

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

azure-pipelines bot commented Apr 25, 2020

azuresdkci commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 26, 2020

azure-pipelines bot commented Apr 27, 2020

saisujithreddym commented Apr 29, 2020

ThreatIntel whitelisting for firewall policy #9224

ThreatIntel whitelisting for firewall policy #9224

Conversation

saisujithreddym commented Apr 25, 2020 • edited by mmyyrroonn Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 25, 2020

openapi-sdkautomation bot commented Apr 25, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Apr 25, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Apr 25, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Apr 25, 2020 • edited Loading

azure-cli-extensions

openapi-sdkautomation bot commented Apr 25, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Apr 25, 2020 • edited Loading

azure-sdk-for-python

azure-pipelines bot commented Apr 25, 2020

azuresdkci commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 25, 2020

azure-pipelines bot commented Apr 26, 2020

azure-pipelines bot commented Apr 27, 2020

saisujithreddym commented Apr 29, 2020

saisujithreddym commented Apr 25, 2020 •

edited by mmyyrroonn

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 25, 2020 •

edited

Loading