Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Portal] Rename one portal cmdlet parameter #9203

Closed
wants to merge 1 commit into from
Closed

[Azure Portal] Rename one portal cmdlet parameter #9203

wants to merge 1 commit into from

Conversation

YalinLi0312
Copy link

@YalinLi0312 YalinLi0312 commented Apr 23, 2020 •
edited
Loading

Globally rename the parameter from "dashboardName" to "name" in az portal.
Related cli extension PR: Azure/azure-cli-extensions#1428

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 23, 2020 •
edited
Loading

azure-cli-extensions

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 3e9af33 with merge commit c9d1c924bfbd9855e4bc5da2ab36dba1d002367a. SDK Automation 13.0.17.20200423.4 
    [AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Dashboards/put/Create or update a Dashboard
[AutoRest]     - name: /Dashboards/get/Get a Dashboard
[AutoRest]     - name: /Dashboards/get/List all custom resource providers on the resourceGroup
[AutoRest]     - name: /Dashboards/get/List all custom resource providers on the subscription
[AutoRest]     - name: /Dashboards/patch/Update a Dashboard
[AutoRest]     - name: /Dashboards/delete/Delete a Dashboard
[AutoRest] --------------------------------------------------------
  • ️✔️portal [Logs]  [Preview SDK Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 23, 2020 •
edited
Loading

azure-sdk-for-js

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 3e9af33 with merge commit c9d1c924bfbd9855e4bc5da2ab36dba1d002367a. SDK Automation 13.0.17.20200423.4 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 23, 2020 •
edited
Loading

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 3e9af33 with merge commit c9d1c924bfbd9855e4bc5da2ab36dba1d002367a. SDK Automation 13.0.17.20200423.4 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 23, 2020 •
edited
Loading

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 23, 2020 •
edited
Loading

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 23, 2020 •
edited
Loading

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 23, 2020 •
edited
Loading

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 3e9af33 with merge commit c9d1c924bfbd9855e4bc5da2ab36dba1d002367a. SDK Automation 13.0.17.20200423.4
  • ⚠️azure-mgmt-portal [Logs]  [Preview SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-portal
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-portal
[build_conf] INFO:packaging_tools:Template done azure-mgmt-portal
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

This was referenced Apr 23, 2020
Open
Open
@YalinLi0312 YalinLi0312 requested a review from RodgeFu April 23, 2020 23:16
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@RodgeFu
Copy link
Member

RodgeFu commented Apr 24, 2020

@fengzhou-msft , i remember you mentioned --dashboard-name should be used instead of --name. could you help to check whether this change is fine? you can find the CLI change introduced at "azure-cli-extensions" comment block above. thanks.

@YalinLi0312
Copy link
Author

Do you mean this comment? I think we agreed on using --name/-n in cmdlet, while @fengzhou-msft prefer using dashboard_name in function's parameter inside file _params.py. And the rename in cmdlet has been approved( portal design spec).
The portal extension customization right now is based on the cmdlet rename codegen result, pls let me know if I need to change the portal extension to the codegen result without cmdlet rename.

@fengzhou-msft
Copy link
Member

fengzhou-msft commented Apr 24, 2020 •
edited
Loading

@YalinLi0312 is right. The generated code should be like c.argument('dashboard_name', options_list=['--name','-n']). However, the configuration would not lead to the right code. We should change the alias instead of name. @qiaozha submitted a PR to add the options in generated code and also the support for configuration.

Let's wait for the release of a new autorest.az. This should be handled automatically. If anything wrong, we can then add the configuration like this.

@RodgeFu
Copy link
Member

RodgeFu commented May 1, 2020

@YalinLi0312 , the support should have been in the beta release below, please give it a try and let us know if there is more issues. thanks.
https://github.com/Azure/autorest.az/releases/tag/1.3.4b2

@PhoenixHe-NV PhoenixHe-NV assigned RodgeFu and unassigned PhoenixHe-NV May 9, 2020
@YalinLi0312
Copy link
Author

YalinLi0312 commented May 11, 2020 •
edited
Loading

Thanks Rodge, I have tried this pre-release version, LGTM. Will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodgeFu RodgeFu Awaiting requested review from RodgeFu

Assignees

@RodgeFu RodgeFu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YalinLi0312 @azuresdkci @RodgeFu @fengzhou-msft @PhoenixHe-NV