Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimalTlsVersion MI/SQL DB property #8358

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Add minimalTlsVersion MI/SQL DB property #8358

merged 4 commits into from
Feb 13, 2020

Conversation

cicovica
Copy link
Contributor

@cicovica cicovica commented Feb 11, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 11, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from f39ba46 with merge commit 0894097. SDK Automation 13.0.17.20191226.1
  • ️✔️sdk/sql/mgmt-v2014_04_01 [Logs]  [Release SDK Changes]
  • ️✔️sdk/sql/mgmt-v2015_05_01_preview [Logs]  [Release SDK Changes]
  • ⚠️sdk/sql/mgmt-v2017_03_01_preview [Logs]  [Release SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
[mvn]   symbol:   class SensitivityLabelSource
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
[mvn] [ERROR]   symbol:   class SensitivityLabelSource
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/sql/mgmt-v2017_10_01_preview [Logs]  [Release SDK Changes] 
        [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/sql/mgmt-v2018_06_01_preview [Logs]  [Release SDK Changes] 
          [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
[mvn]   symbol:   class SensitivityLabelSource
[mvn]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
[mvn] [ERROR]   symbol:   class SensitivityLabelSource
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Feb 11, 2020 •
        edited
        Loading

        azure-sdk-for-go - Release

        ⚠️ warning [Logs] [Expand Details]

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Feb 11, 2020 •
        edited
        Loading

        azure-sdk-for-js - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from f39ba46 with merge commit 0894097. SDK Automation 13.0.17.20191226.1
        • ️✔️@azure/arm-sql [Logs]  [Release SDK Changes] 
          [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
[npmPack] created ./dist/arm-sql.js in 1.8s

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Feb 11, 2020 •
        edited
        Loading

        azure-sdk-for-net - Release

        🔄 inProgress [Logs] [Expand Details]
        • 🔄 Generate from f39ba46 with merge commit 0894097. SDK Automation 13.0.17.20191226.1

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Feb 11, 2020 •
        edited
        Loading

        azure-sdk-for-python - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from f39ba46 with merge commit 0894097. SDK Automation 13.0.17.20191226.1
        • ️✔️azure-mgmt-sql [Logs]  [Release SDK Changes] 
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

        This was referenced Feb 11, 2020
        Closed
        Closed
        Closed
        Closed
        Closed
        Closed
        Closed
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @cicovica cicovica changed the title [DO NOT MERGE] Add minimalTlsVersion MI/SQL DB property Add minimalTlsVersion MI/SQL DB property Feb 11, 2020
        @cicovica cicovica marked this pull request as ready for review February 11, 2020 17:52
        @cicovica cicovica requested a review from jaredmoo as a code owner February 11, 2020 17:52
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @majastrz majastrz added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 12, 2020
        majastrz
        majastrz approved these changes Feb 12, 2020
        View reviewed changes
        Copy link
        Member

        @majastrz majastrz left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        Signed off from ARM side.

        @zikalino zikalino merged commit 0894097 into Azure:master Feb 13, 2020
        ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
        @cicovica @ssripadham
        Add minimalTlsVersion MI/SQL DB property (Azure#8358)
        e5fa1e7 
        * Add minimalTlsVersion parameter for Managed Instance and SQL DB

* Revert "Add minimalTlsVersion parameter for Managed Instance and SQL DB"

This reverts commit df99a4e.

* Add minimalTlsVersion parameter for MI

* Add minimalTlsVersion parameter for SQL DB
        @ziwa-msft ziwa-msft mentioned this pull request Feb 25, 2020
        Merged
        4 tasks
        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
        @cicovica @00Kai0
        Add minimalTlsVersion MI/SQL DB property (Azure#8358)
        1489a4f 
        * Add minimalTlsVersion parameter for Managed Instance and SQL DB

* Revert "Add minimalTlsVersion parameter for Managed Instance and SQL DB"

This reverts commit df99a4e.

* Add minimalTlsVersion parameter for MI

* Add minimalTlsVersion parameter for SQL DB
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Reviewers

        @zikalino zikalino zikalino approved these changes

        @majastrz majastrz majastrz approved these changes

        @jaredmoo jaredmoo Awaiting requested review from jaredmoo

        Assignees

        @zikalino zikalino

        Labels
        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
        Projects
        None yet
        Milestone
        No milestone
        Development

        Successfully merging this pull request may close these issues.
        3 participants
        @cicovica @zikalino @majastrz