Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blob] Added missing headers for copy blob from URL #7820

Merged
merged 1 commit into from
Nov 26, 2019
Merged

[Blob] Added missing headers for copy blob from URL #7820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 33 additions & 20 deletions specification/storage/data-plane/Microsoft.BlobStorage/preview/2019-02-02/blob.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2944,7 +2944,7 @@
"type": "integer",
"description": "The number of committed blocks present in the blob. This header is returned only for append blobs."
},
"x-ms-server-encrypted": {
"x-ms-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
"description": "The value of this header is set to true if the blob data and application metadata are completely encrypted using the specified algorithm. Otherwise, the value is set to false (when the blob is unencrypted, or if only parts of the blob/application metadata are encrypted)."
Expand Down Expand Up @@ -3156,7 +3156,7 @@
"type": "integer",
"description": "The number of committed blocks present in the blob. This header is returned only for append blobs."
},
"x-ms-server-encrypted": {
"x-ms-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
"description": "The value of this header is set to true if the blob data and application metadata are completely encrypted using the specified algorithm. Otherwise, the value is set to false (when the blob is unencrypted, or if only parts of the blob/application metadata are encrypted)."
Expand Down Expand Up @@ -3433,7 +3433,7 @@
"type": "integer",
"description": "The number of committed blocks present in the blob. This header is returned only for append blobs."
},
"x-ms-server-encrypted": {
"x-ms-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
"description": "The value of this header is set to true if the blob data and application metadata are completely encrypted using the specified algorithm. Otherwise, the value is set to false (when the blob is unencrypted, or if only parts of the blob/application metadata are encrypted)."
Expand Down Expand Up @@ -4056,11 +4056,11 @@
"type": "string",
"format": "date-time-rfc1123",
"description": "UTC date/time value generated by the service that indicates the time at which the response was initiated"
},
"x-ms-request-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
"description": "The value of this header is set to true if the contents of the request are successfully encrypted using the specified algorithm, and false otherwise."
},
"x-ms-request-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
"description": "The value of this header is set to true if the contents of the request are successfully encrypted using the specified algorithm, and false otherwise."
},
"x-ms-encryption-key-sha256": {
"x-ms-client-name": "EncryptionKeySha256",
Expand Down Expand Up @@ -4209,7 +4209,7 @@
"type": "string",
"format": "date-time-rfc1123",
"description": "UTC date/time value generated by the service that indicates the time at which the response was initiated"
},
},
"x-ms-request-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
Expand Down Expand Up @@ -4272,7 +4272,7 @@
{
"$ref": "#/parameters/Timeout"
},
{
{
"$ref": "#/parameters/ContentMD5"
},
{
Expand Down Expand Up @@ -4371,7 +4371,7 @@
"type": "string",
"format": "date-time-rfc1123",
"description": "UTC date/time value generated by the service that indicates the time at which the response was initiated"
},
},
"x-ms-request-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
Expand Down Expand Up @@ -5602,6 +5602,9 @@
},
{
"$ref": "#/parameters/ClientRequestId"
},
{
"$ref": "#/parameters/SourceContentMD5"
}
],
"responses": {
Expand Down Expand Up @@ -5654,6 +5657,16 @@
"name": "SyncCopyStatusType",
"modelAsString": false
}
},
"Content-MD5": {
"type": "string",
"format": "byte",
"description": "This response header is returned so that the client can check for the integrity of the copied content. This header is only returned if the source content MD5 was specified."
},
"x-ms-content-crc64": {
"type": "string",
"format": "byte",
"description": "This response header is returned so that the client can check for the integrity of the copied content."
Comment on lines +5661 to +5669
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any APIs with both of these yet? This might need a bit of discussion to get right for .NET.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add "x-ms-client-name": "Content-CRC64" to x-ms-content-crc64.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was holding off on the nice name for consistency reasons, as the other instances didn't have it.

Copy link
Contributor

@xiafu-msft xiafu-msft Nov 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tg-msft stage_block_from_url has these two headers
https://github.com/zezha-msft/azure-rest-api-specs/blob/5504d99b737b1deaa7b6ce4518e90689e804c975/specification/storage/data-plane/Microsoft.BlobStorage/preview/2019-02-02/blob.json#L6167-L6176

}
}
},
Expand Down Expand Up @@ -6043,7 +6056,7 @@
"type": "string",
"format": "date-time-rfc1123",
"description": "UTC date/time value generated by the service that indicates the time at which the response was initiated"
},
},
"x-ms-content-crc64": {
"type": "string",
"format": "byte",
Expand Down Expand Up @@ -6145,7 +6158,7 @@
},
{
"$ref": "#/parameters/ClientRequestId"
}
}
],
"responses": {
"201": {
Expand Down Expand Up @@ -6180,7 +6193,7 @@
"type": "string",
"format": "date-time-rfc1123",
"description": "UTC date/time value generated by the service that indicates the time at which the response was initiated"
},
},
"x-ms-request-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
Expand Down Expand Up @@ -6342,7 +6355,7 @@
"type": "string",
"format": "date-time-rfc1123",
"description": "UTC date/time value generated by the service that indicates the time at which the response was initiated"
},
},
"x-ms-request-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
Expand Down Expand Up @@ -6588,7 +6601,7 @@
"type": "string",
"format": "date-time-rfc1123",
"description": "UTC date/time value generated by the service that indicates the time at which the response was initiated"
},
},
"x-ms-request-server-encrypted": {
"x-ms-client-name": "IsServerEncrypted",
"type": "boolean",
Expand Down Expand Up @@ -6829,7 +6842,7 @@
{
"$ref": "#/parameters/RangeRequiredPutPageFromUrl"
},
{
{
"$ref": "#/parameters/EncryptionKey"
},
{
Expand Down Expand Up @@ -7711,18 +7724,18 @@
"$ref": "#/parameters/SourceContentMD5"
},
{
"$ref": "#/parameters/SourceContentCRC64"
"$ref": "#/parameters/SourceContentCRC64"
},
{
"$ref": "#/parameters/Timeout"
},
{
"$ref": "#/parameters/ContentLength"
},
{
{
"$ref": "#/parameters/ContentMD5"
},
{
{
"$ref": "#/parameters/EncryptionKey"
},
{
Expand Down