Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EU compliance not to description #7610

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Adding EU compliance not to description #7610

merged 3 commits into from
Oct 29, 2019

Conversation

swhite-msft
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2019

In Testing, Please Ignore

[Logs] (Generated from edd3ba7, Iteration 3)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/cognitiveservices-visualsearch [Logs]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6172

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@swhite-msft
Copy link
Contributor Author

#sign-off

@zikalino
Copy link

approved, but we need to fix (or disable as they are unrelated) ci errors

@swhite-msft
Copy link
Contributor Author

thanks, how do we fix or disable those checks? FYI, there is some urgency to getting this published today to meet EU compliance requirements.

@zikalino
Copy link

@swhite-msft html tags should be removed as it breaks doc generation, and then we should be able to force merge this pr

@swhite-msft
Copy link
Contributor Author

@zikalino We need to be able to set off that note to make it visible. Is there a way to do what the HTML tags are trying to do? Also, I used the tags because they worked in https://editor.swagger.io, so I thought we'd support them. Is there a doc somewhere that spells out what we can use to format swagger content, so it doesn't look like one big long string? Thanks

@swhite-msft
Copy link
Contributor Author

#sign-off

@swhite-msft
Copy link
Contributor Author

@zikalino I removed the html tags. please force merge. thx

@swhite-msft
Copy link
Contributor Author

@zikalino, what do I need to do to get this PR merged?

@zikalino
Copy link

I approved already

@yungezz yungezz merged commit f36ceea into Azure:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants