Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting the verbs from Create BillingProfile and InvoiceSection as per code implementation #7524

Merged
merged 14 commits into from
Oct 21, 2019
Merged

Correcting the verbs from Create BillingProfile and InvoiceSection as per code implementation #7524

merged 14 commits into from
Oct 21, 2019

Conversation

asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Oct 16, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

asarkar84 added 14 commits August 14, 2019 17:11
@asarkar84
Billing RP spec changes for listInvoiceSectionsWithCreateSubscription…
8294a82 
…Permission API
@asarkar84
Updated the operation id
ea78887
@asarkar84
Added x-ms-pageable
8cc7de3
@asarkar84
Added next link
448fd07
@asarkar84
Deleted unused file ProductCancelByBillingAccount
b5edf02
@asarkar84
Incorporated review comments
fa4f267 
Incorporated review comments
@asarkar84
Merge remote-tracking branch 'upstream/master'
334640e
@asarkar84
Added new properties in Invoicing APIs
c173f14 
Added new properties in Invoicing APIs
@asarkar84
Incorporated review comments
9380490 
Incorporated review comments
@asarkar84
Added invoiceEmailOptIn in the UpdateBillingProfile request
cf244f2 
Added invoiceEmailOptIn in the UpdateBillingProfile request
@asarkar84
Merge remote-tracking branch 'upstream/master'
b08cb07
@asarkar84
Update billing.json
00e9a8b
@asarkar84
Merge remote-tracking branch 'upstream/master'
b645a83
@asarkar84
Updating the verbs from Create BillingProfile and InvoiceSection enti…
9ff123a 
…ties

Updating the verbs from Create BillingProfile and InvoiceSection entities
@asarkar84 asarkar84 requested a review from wilcobmsft as a code owner October 16, 2019 19:00
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 16, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 9ff123a, Iteration 2)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed billing/resource-manager/v2017_02_27_preview [Logs]
  • Failed billing/resource-manager/v2017_04_24_preview [Logs]
  • Failed billing/resource-manager/v2018_03_01_preview [Logs]
  • Failed billing/resource-manager/v2018_11_01_preview [Logs]
  • Failed billing/resource-manager/v2019_10_01_preview [Logs]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci azuresdkci requested a review from raych1 October 16, 2019 19:01
@AutorestCI AutorestCI mentioned this pull request Oct 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7948

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Oct 16, 2019
Merged
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@raych1
Copy link
Member

raych1 commented Oct 17, 2019 •
edited
Loading

@wilcobmsft, can you confirm the change on service side for this PR? Thanks.

@raych1
Copy link
Member

raych1 commented Oct 18, 2019

@asarkar84 , looks like @wilcobmsft is OOF, can you have others approve this PR on behalf of code owner?

@asarkar84
Copy link
Contributor Author

asarkar84 commented Oct 19, 2019 •
edited
Loading

@raych1 In Wilco's absence, I got approval from Adrian from my team. Please approve and merge this PR.
Thanks!

@raych1 raych1 merged commit 4d8c0af into Azure:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raych1 raych1 raych1 approved these changes

@msft-adrianma msft-adrianma msft-adrianma approved these changes

@wilcobmsft wilcobmsft Awaiting requested review from wilcobmsft wilcobmsft is a code owner

Assignees

@raych1 raych1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asarkar84 @AutorestCI @azuresdkci @raych1 @msft-adrianma