Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Search] Apply branding changes to stable/2019-05-06 and track1/stable/2019-05-06 #7511

Merged
merged 2 commits into from
Oct 21, 2019
Merged

[Azure Search] Apply branding changes to stable/2019-05-06 and track1/stable/2019-05-06 #7511

merged 2 commits into from
Oct 21, 2019

Conversation

bleroy
Copy link
Contributor

@bleroy bleroy commented Oct 16, 2019

This applies branding changes from "Azure Search" to "Azure Cognitive Search".

@bleroy bleroy requested a review from brjohnstmsft as a code owner October 16, 2019 00:20
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 16, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from e4f3a84, Iteration 4)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • search/data-plane/Microsoft.Azure.Search.Data/track1
  • search/data-plane/Microsoft.Azure.Search.Data
  • search/data-plane/Microsoft.Azure.Search.Service

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Service
  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • search/data-plane/Microsoft.Azure.Search.Data/track1
  • search/data-plane/Microsoft.Azure.Search.Data

arv100kri
arv100kri requested changes Oct 16, 2019
View reviewed changes
Copy link
Member

@arv100kri arv100kri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to update the references in the following as well

https://github.com/Azure/azure-rest-api-specs/tree/a497484db69d4d468e111972e25f939ef26af2b7/specification/search/data-plane/Microsoft.Azure.Search.Data/stable/2019-05-06

https://github.com/Azure/azure-rest-api-specs/blob/a497484db69d4d468e111972e25f939ef26af2b7/specification/search/data-plane/Microsoft.Azure.Search.Data/track1/stable/2019-05-06/searchindex.json

@bleroy bleroy force-pushed the beleroy/branding-azure-cognitive-search branch from a497484 to 1e842c3 Compare October 16, 2019 00:39
@azuresdkci azuresdkci requested a review from sarangan12 October 16, 2019 00:54
arv100kri
arv100kri requested changes Oct 16, 2019
View reviewed changes
Copy link
Member

@arv100kri arv100kri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments - once addressed I am ready to sign off :)

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@arv100kri
Copy link
Member

Context -
@sarangan12 - We are rebranding the concept/entity "Azure Search" to "Azure Cognitive Search" and we'd like that to be reflected in our SDK generated doc comments. This achieves that

@HeidiSteen - This is the logic we applied
In places where the term "Azure Search" is used as is (to reference a concept), we replace it with "Azure Cognitive Search".

In places where the term "Azure Search" is followed by a noun ("Azure Search service", "Azure search index", "Azure search indexer etc.,") we simply contract it to "search" + noun or remove "search" altogether as appropriate ("search service", "index", "indexer" etc.,)

HeidiSteen
HeidiSteen approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@HeidiSteen HeidiSteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bleroy Your PR didn't pass validation. You should close and reopen the PR to see if the problem is transitory. I agree with all of Arvind's comments.

@arv100kri
Copy link
Member

@bleroy Your PR didn't pass validation. You should close and reopen the PR to see if the problem is transitory. I agree with all of Arvind's comments.

@HeidiSteen / @sarangan12 / @bleroy - the model validation failures are due to a "ENUM_MISMATCH" which is a known failure mode and we have obtained exceptions from the swagger folks.

@bleroy bleroy requested a review from arv100kri October 16, 2019 19:16
@arv100kri
Copy link
Member

@sarangan12 - @brjohnstmsft is on vacation, and I think my sign off is a reasonable substitute.
Could you please merge this pull request at your earliest?

@arv100kri arv100kri changed the title Apply branding changes to stable/2019-05-06 and track1/stable/2019-05-06 [Azure Search] Apply branding changes to stable/2019-05-06 and track1/stable/2019-05-06 Oct 18, 2019
@sergey-shandar sergey-shandar merged commit 4032496 into Azure:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arv100kri arv100kri arv100kri approved these changes

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@HeidiSteen HeidiSteen HeidiSteen approved these changes

@brjohnstmsft brjohnstmsft Awaiting requested review from brjohnstmsft

@sarangan12 sarangan12 Awaiting requested review from sarangan12

Assignees
No one assigned
Labels
Reassign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bleroy @AutorestCI @azuresdkci @arv100kri @sergey-shandar @HeidiSteen @sarangan12