Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omelhari/feature assigning ap is #7503

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

omar-el-hariry
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 15, 2019

In Testing, Please Ignore

[Logs] (Generated from 6fe4f80, Iteration 4)

Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/cognitiveservices-luis-authoring [Logs]

@msftclas
Copy link

msftclas commented Oct 15, 2019

CLA assistant check
All CLA requirements met.

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpm0jc5oqp/rest/specification/cognitiveservices/data-plane/LUIS/Authoring/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpm0jc5oqp/sdk/sdk', '--use=@microsoft.azure/autorest.python@~4.0.71', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~4.0.71->4.0.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR: Referenced file 'file:///tmp/tmpm0jc5oqp/rest/specification/cognitiveservices/data-plane/LUIS/Authoring/preview/v3.0/examples/features/SuccessfulAddFeatureRelationRequest.json' not found
    - file:///tmp/tmpm0jc5oqp/rest/specification/cognitiveservices/data-plane/LUIS/Authoring/preview/v3.0/LUIS-Authoring.json:1542:12 ($.paths["/apps/{appId}/versions/{versionId}/entities/{entityId}/features"].post["x-ms-examples"]["Successful Add Feature Relation request"]["$ref"])
FATAL: swagger-document/loader - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anuchandy
Copy link
Member

Please take a look at validation errors reported here: https://dev.azure.com/azure-sdk/public/_build/results?buildId=145277 ,

@omar-el-hariry omar-el-hariry force-pushed the omelhari/Feature_assigning_APIs branch from ad0367a to ef17414 Compare October 21, 2019 18:01
@omar-el-hariry omar-el-hariry force-pushed the omelhari/Feature_assigning_APIs branch from ef17414 to 6fe4f80 Compare October 21, 2019 18:10
@omar-el-hariry
Copy link
Contributor Author

I've fixed the errors, can you take a look and tell me if anything else is needed?

@anuchandy
Copy link
Member

Confirmed with service team that, this version is already deployed and went through API Review board. Merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants