Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hybrid RP rest api spec #7487

Merged
merged 11 commits into from
Oct 22, 2019
Merged

Add Hybrid RP rest api spec #7487

merged 11 commits into from
Oct 22, 2019

Conversation

farehar
Copy link
Contributor

@farehar farehar commented Oct 14, 2019

Our rest api spec was merged in the private specs repository: https://github.com/Azure/azure-rest-api-specs-pr/pull/896. Adding it to public repository now.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 14, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 675c1b3, Iteration 12)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Oct 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci azuresdkci requested a review from raych1 October 14, 2019 21:15
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 15, 2019
@raych1
Copy link
Member

raych1 commented Oct 15, 2019

@yaohaizh @zikalino @ArcturusZhang @erich-wang, this is a new RP, please review on readme.md for JAVA,Phthon,Go and .net/powershell configurations, thanks.

yaohaizh
yaohaizh approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@yaohaizh yaohaizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for java generation section

@farehar
Copy link
Contributor Author

farehar commented Oct 16, 2019

@raych1 : I've resolved all the comments. Please take a look and merge if everything looks good.

@raych1
Copy link
Member

raych1 commented Oct 16, 2019

@farehar , the fix looks good to me. It still needs ARM team sign off to merge.

KrisBash
KrisBash suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor items to address

@KrisBash KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 16, 2019
@farehar
Copy link
Contributor Author

farehar commented Oct 16, 2019

@KrisBash : Updated per your feedback. Please review and sign off/merge. Thank you!!

@raych1 raych1 requested a review from KrisBash October 17, 2019 01:15
KrisBash
KrisBash approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 18, 2019
@raych1 raych1 closed this Oct 21, 2019
@raych1 raych1 reopened this Oct 21, 2019
@raych1
Copy link
Member

raych1 commented Oct 21, 2019

@farehar , please refer to the error logs and fix CI failures. The response definition doesn't match between example and spec.

@farehar
Copy link
Contributor Author

farehar commented Oct 21, 2019

@raych1 : updated the examples.

@raych1 raych1 merged commit f243746 into Azure:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@yaohaizh yaohaizh yaohaizh approved these changes

@raych1 raych1 raych1 approved these changes

Assignees

@raych1 raych1

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@farehar @AutorestCI @azuresdkci @raych1 @KrisBash @ArcturusZhang @yaohaizh