Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AKS rotateClusterCertificates API #7436

Merged
merged 2 commits into from
Oct 21, 2019
Merged

add AKS rotateClusterCertificates API #7436

merged 2 commits into from
Oct 21, 2019

Conversation

andyzhangx
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

/hold

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 9, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 965878a, Iteration 6)

Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Oct 9, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 9, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8062

@AutorestCI AutorestCI mentioned this pull request Oct 9, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 9, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6095

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 9, 2019
Closed
@andyzhangx
Copy link
Contributor Author

hold on this PR until original AKS rotate-certs code merged into AKS code branch.

@jhendrixMSFT jhendrixMSFT added DoNotMerge <valid label in PR review process> use to hold merge after approval WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 9, 2019
KrisBash
KrisBash approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off with comment. If there are response bodies for the action, please model those in swagger.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 9, 2019
@andyzhangx
Copy link
Contributor Author

cc @yangl900 @weinong for review

@jhendrixMSFT
Copy link
Member

@andyzhangx hello any update?

This was referenced Oct 19, 2019
Closed
Merged
@andyzhangx
Copy link
Contributor Author

@andyzhangx hello any update?

the rotateClusterCertificates API has been merged in AKS, and I have removed 200 response in the PR. Why is this PR failing? @jhendrixMSFT

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 19, 2019
Closed
@andyzhangx andyzhangx changed the title [WIP]add aks rotate-certs operation for 2019-08-01 add aks rotate-certs operation for 2019-08-01 Oct 19, 2019
@andyzhangx andyzhangx changed the title add aks rotate-certs operation for 2019-08-01 add AKS rotateClusterCertificates API for 2019-08-01 Oct 19, 2019
@andyzhangx andyzhangx changed the title add AKS rotateClusterCertificates API for 2019-08-01 add AKS rotateClusterCertificates API Oct 19, 2019
@andyzhangx
Copy link
Contributor Author

@jhendrixMSFT I have updated this PR, pls take a review, thanks.

@jhendrixMSFT jhendrixMSFT removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 21, 2019
@jhendrixMSFT jhendrixMSFT merged commit 6004a8b into Azure:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andyzhangx @AutorestCI @azuresdkci @jhendrixMSFT @KrisBash