Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregated alert top devices information #7409

Merged
merged 8 commits into from
Oct 9, 2019
Merged

Add aggregated alert top devices information #7409

merged 8 commits into from
Oct 9, 2019

Conversation

hagba
Copy link
Contributor

@hagba hagba commented Oct 7, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 7, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 83f1e75, Iteration 10)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Oct 7, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7649

@azuresdkci azuresdkci requested a review from erich-wang October 7, 2019 10:18
@AutorestCI
Copy link

AutorestCI commented Oct 7, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5984

@hagba hagba changed the title [Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 Add aggregated alert top devices information Oct 7, 2019
@hagba hagba added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 7, 2019
This was referenced Oct 7, 2019
Merged
Merged
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

KrisBash
KrisBash approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 8, 2019
@erich-wang erich-wang merged commit 9fb60f2 into Azure:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@erich-wang erich-wang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hagba @AutorestCI @azuresdkci @KrisBash @erich-wang