Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Computer Vision] Create CV API v3.0-preview #7402

Merged
merged 11 commits into from
Mar 19, 2020

Conversation

TFR258
Copy link
Contributor

@TFR258 TFR258 commented Oct 4, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 4, 2019

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 96425e0 with merge commit 24e574c. SDK Automation 13.0.17.20200311.2
    Failed to find any changed packages. Please check the changed file list.
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/ComputerVisionClient.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/implementation/ComputerVisionClientImpl.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/implementation/package-info.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/AdultInfo.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/AreaOfInterestResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/BatchReadFileHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/BatchReadFileInStreamHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/BoundingRect.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/Category.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/CategoryDetail.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/CelebritiesModel.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/CelebrityResults.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ColorInfo.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ComputerVisionError.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ComputerVisionErrorException.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/DescriptionExclude.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/Details.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/DetectResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/DetectedBrand.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/DetectedObject.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/DomainModelResults.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/FaceDescription.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/FaceRectangle.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/Gender.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageAnalysis.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageCaption.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageDescription.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageDescriptionDetails.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageMetadata.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageTag.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageType.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ImageUrl.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/LandmarkResults.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/LandmarksModel.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/Line.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ListModelsResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ModelDescription.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ObjectHierarchy.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/OcrLanguages.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/OcrLine.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/OcrRegion.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/OcrResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/OcrWord.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/ReadOperationResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/RecognizeTextHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/RecognizeTextInStreamHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/TagResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/TextOperationResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/TextOperationStatusCodes.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/TextRecognitionMode.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/TextRecognitionResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/TextRecognitionResultConfidenceClass.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/TextRecognitionResultDimensionUnit.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/VisualFeatureTypes.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/Word.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/models/package-info.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/computervision/src/main/java/com/microsoft/azure/cognitiveservices/vision/computervision/package-info.java

@AutorestCI
Copy link

AutorestCI commented Oct 4, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 4, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6367

@TFR258
Copy link
Contributor Author

TFR258 commented Oct 4, 2019

@bojunehsu , the PR is ready

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@TFR258
Copy link
Contributor Author

TFR258 commented Oct 4, 2019

We are currently waiting on the API review

@TFR258 TFR258 force-pushed the threis/OCR_v3.0 branch 2 times, most recently from d03f4f8 to c4f0d09 Compare October 4, 2019 09:57
@TFR258
Copy link
Contributor Author

TFR258 commented Oct 9, 2019

@ryogok , This is our latest APIM set of changes for the OCR release

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared this v3 with current v2, changes looks minimal. LGTM.

@anuchandy
Copy link
Member

@TFR258 did we deploy this version of vision to at-least one production region? a deployment is needed for PR to merge to master.

@TFR258 TFR258 force-pushed the threis/OCR_v3.0 branch 3 times, most recently from 0fddbd2 to d3ad95b Compare October 19, 2019 07:31
@anuchandy
Copy link
Member

@TFR258 is this deployed to at least one production region?

@TFR258
Copy link
Contributor Author

TFR258 commented Nov 13, 2019 via email

@anuchandy anuchandy added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 1, 2019
@anuchandy anuchandy changed the title [Computer Vision] Create CV API v3.0 [DON'T MERGE] [Computer Vision] Create CV API v3.0 Dec 1, 2019
@TFR258
Copy link
Contributor Author

TFR258 commented Dec 13, 2019

Hi @anuchandy ,
We have rolled out in Canary and one prod regions.
I see you have marked the PR as DO NOT MERGE.
Let me know when it would be best for us to sync.
Thanks,
Tom

@TFR258 TFR258 requested a review from anuchandy December 13, 2019 08:24
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 12, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 96425e0 with merge commit 24e574c. SDK Automation 13.0.17.20200311.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 12, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@TFR258
Copy link
Contributor Author

TFR258 commented Mar 12, 2020

@anuchandy , can you help us approve this PR?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 12, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 7402 in repo Azure/azure-rest-api-specs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TFR258 TFR258 changed the title [DON'T MERGE] [Computer Vision] Create CV API v3.0 [DON'T MERGE] [Computer Vision] Create CV API v3.0-preview Mar 17, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 17, 2020

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@TFR258 TFR258 changed the title [DON'T MERGE] [Computer Vision] Create CV API v3.0-preview [Computer Vision] Create CV API v3.0-preview Mar 18, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmazuel lmazuel merged commit 24e574c into Azure:master Mar 19, 2020
iscai-msft added a commit that referenced this pull request Mar 20, 2020
…into keyvault_multiapi_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits)
  add cli.md for automation (#8411)
  adjust assignment (#8782)
  Remove Microsoft.Backup.Admin 2016-05-01 API version (#8588)
  Updating global setting in PostgreSQL/MySQL readme file (#8777)
  update package name and output folder in readme.typescript.md (#8764)
  add package-2019-12 python define (#8769)
  Fix Parameter Description for validate resource move (#8524)
  Edit pass for GA swagger (#8759)
  Update proxy.json (#8596)
  Model enums that may change in the future as strings (#8760)
  Add api-version 2019-11-01 for resources/subscriptions (#8728)
  regenerated all-api-versions
  PrivateLinkResources for Microsoft.Automation (#8369)
  add cli.md for serialconsole (#8401)
  add cli.md for mariadb (#8466)
  [Computer Vision] Create CV API v3.0-preview (#7402)
  Publish Microsoft.ContainerService api-version 2020-03-01 (#8756)
  Update swagger based on auto-gen process change. (#8766)
  add assignment-bot config (#8716)
  add tag package-2019-12 to batch (#8751)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* [Computer Vision] Add Computer Vision v3.0 base config

* [Computer Vision] Add OCR v3.0 API changes

* Swap Analyze Post response back to 202

* Update version number to preview and revert location to Operation-Location

* Minor corrections after review with Paul

* Update Read API POST/Get and make Read language parameter optional

* Update CV base path to v3.0-preview

Update comment to re-trigger a build

* Remove all but OCR APIs in 3.0-preview

* Make Page level language tag optional

* Fix code style

* update path of ocr swagger to v3.0-preview and add date format

Co-authored-by: bob <bob@bob.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants