Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual network gateway changes for dns forwarding #7359

Conversation

absrivas12
Copy link

This pull request introduces a new boolean flag enableDnsForwarding on the VirtualNetworkGateway resource. The flag can be set to true or false using the PUT operation on VirtualNetworkGateway. If the flag is not specified then it is a no op on the resource provider.
The pull request also adds a string property called inboundDnsForwardingEndpoint which is a readonly property, set automatically when PUT with enableDnsForwarding set to true succeeds.

When a PUT operation is done where enableDnsForwarding is true, it enables the DNS forwarding functionality on the virtual network gateway, and the gateway can be used as a dns forwarder. After successful completion of operation the users will be able to send DNS requests to the gateway at the IP address specified by the inboundDnsForwardingEndpoint property. This is a readonly property whose value is automatically set by the resource provider on the VirtualNetworkGateway resource.

Users can also disable dns forwarding functionality on the gateway by using a PUT where enableDnsForwarding is set to false.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@absrivas12 absrivas12 changed the title Virtuan network gateway changes for dns forwarding Virtual network gateway changes for dns forwarding Sep 30, 2019
@msftclas
Copy link

msftclas commented Sep 30, 2019

CLA assistant check
All CLA requirements met.

@AutorestCI
Copy link

AutorestCI commented Sep 30, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmppp8df_i8/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmppp8df_i8/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[8410:0x2937cc0]   145567 ms: Mark-sweep 1381.2 (1427.3) -> 1381.2 (1427.8) MB, 2614.3 / 0.0 ms  (average mu = 0.095, current mu = 0.001) allocation failure GC in old space requested
[8410:0x2937cc0]   148282 ms: Mark-sweep 1381.9 (1427.8) -> 1381.8 (1428.3) MB, 2711.7 / 0.0 ms  (average mu = 0.051, current mu = 0.001) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x1030b675be1d]
Security context: 0x11640e21e6e9 <JSObject>
    1: newScalar [0xd7fea07b841] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0x1030b6fc3276](this=0x25a38732dc71 <Object map = 0x1ac7649c4e61>,v=0x3ca8e48026f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x25a38732e571] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [pc...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x1030b675be1d

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 30, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@anton-evseev anton-evseev added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 30, 2019
Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one thing

@@ -23,6 +23,7 @@
"gatewayType": "Vpn",
"vpnType": "RouteBased",
"enableBgp": false,
"enableDnsForwarding": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add new properties in example response (since without them it's not acquirate)

@ryansbenson ryansbenson added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 30, 2019
@anton-evseev anton-evseev assigned tjprescott and unassigned lirenhe Oct 2, 2019
@anton-evseev
Copy link
Contributor

@tjprescott assigning this to you since Catherine Zhu said you're one of those who would cover for Chinese team during their long holiday. Could you please merge this PR?

@tjprescott tjprescott merged commit 7fde8a0 into Azure:network-september-release Oct 2, 2019
sergey-shandar pushed a commit that referenced this pull request Oct 2, 2019
* Adds base for updating Microsoft.Network from version stable/2019-07-01 to version 2019-08-01

* Updates readme

* Updates API version in new specs and examples

* Add reference to Connection Monitor specs in 2019-08-01 (#7218)

* Support AH protocol (#7231)

* Virtual Network BGP Communities (#7248)

* Virtual Wan point to site feature redesign:- (#7238)

* Virtual Wan point to site feature redesign

* Fix examples

* Fix validation errors

* Fix validation error

* Fix validation errors

* Incorporate review comments

* Fix default error in standard error response

* Fix validation error

* Refer to default error from ddos swagger spec

* Fix build error

* Firewall Manager Feature Swagger Updates for Public Preview (#7266)

* Adding the structure of urlConfiguration in rewriteRuleActionSet (#7275)

* Revert "Adding the structure of urlConfiguration in rewriteRuleActionSet (#7275)" (#7333)

This reverts commit e89f35d.

* Virtual network gateway changes for dns forwarding (#7359)

* Virtuan network gateway changes for dns forwarding

* Fixed example response

* Fixed examples

* Fixed 201 example

* Top-level WAF (#7222)

* Move new props to the end to avoid breaking changes in SDK (#7387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants