Cosmos DB patch and multi-api support #7336

shurd · 2019-09-26T20:10:05Z

This change introduces patch support in the new API version and splits "createOrUpdate" into "create" and "update". No SDKs have been generated based on this new version yet. The new patch properties are identical to the "update" properties except "locations" is optional and offer type is not a part of the payload.

This change also adds "locations" in the database account response to help resolve Azure/azure-sdk-for-python#6823

This change also enable multiple-api version support for python, java and go libraries. I copied the formatting from other providers, but am not sure how to validate how this works. Most importantly, python code is now generated in subdirectories of the current python project. I am not sure how that will impact the existing code (if it needs to be deleted since it will not be replaced). This change also references a preview version, which is added in #7249. This change should be merged after that.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-26T20:10:09Z

In Testing, Please Ignore

[Logs] (Generated from b278a4f, Iteration 9)

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-cosmosdb [Logs] [Instructions] [Generation PR]
- azure-mgmt-cosmosdb-0.8.0.zip
- azure_mgmt_cosmosdb-0.8.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

cosmosdb/resource-manager/v2015_04_08 [Logs] [Instructions]
cosmosdb/resource-manager/v2019_08_01 [Logs]
cosmosdb/resource-manager/v2019_08_01_preview [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

cosmos-db/mgmt/2015-04-08 [Logs] [Instructions] [Generation PR]
- cosmos-db.mgmt.2015-04-08.zip
cosmos-db/mgmt/2019-08-01-preview [Logs] [Instructions] [Generation PR]
- cosmos-db.mgmt.2019-08-01-preview.zip
cosmos-db/mgmt/2019-08-01 [Logs] [Instructions] [Generation PR]
- cosmos-db.mgmt.2019-08-01.zip

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-cosmosdb [Logs] [Instructions]
- azure-arm-cosmosdb-4.0.0.tgz

AutorestCI · 2019-09-26T20:11:10Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6190

AutorestCI · 2019-09-26T20:11:13Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpbkuv84jh/rest/specification/cosmos-db/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmphh6xz913']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

azuresdkci · 2019-09-26T21:00:30Z

Can one of the admins verify this patch?

ravbhatnagar

@shurd - few comments

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2019-08-01/cosmos-db.json

ArcturusZhang

Please add these new swagger files in readme corresponding to their tags, see this file for an example.
This is the reason why some SDK automation fails

shurd · 2019-09-29T07:39:55Z

@ArcturusZhang I think that I have the readme file correct, but it depends on this change - #7249. I just added the necessary changes for that new file so that we would not have to open another PR. I'll re-run the automation after that PR is merged (which it is ready to be merged).

ArcturusZhang · 2019-09-29T07:54:10Z

@ArcturusZhang I think that I have the readme file correct, but it depends on this change - #7249. I just added the necessary changes for that new file so that we would not have to open another PR. I'll re-run the automation after that PR is merged (which it is ready to be merged).

Sure, thanks!

shurd · 2019-10-02T00:39:50Z

@ArcturusZhang, I am removing those changes so that SDKs can be generated since we want to expedite this change. @ravbhatnagar can you please re-review this? We are hesitant to leave the method named "CreateOrUpdate".

…python, go, java, adding new property from database account resource, adding locations to response of database accounts

ravbhatnagar · 2019-10-17T18:10:19Z

@shurd - please take a look at the response

shurd · 2019-10-18T00:38:03Z

@ravbhatnagar I have made the renaming change.

ArcturusZhang

LGTM

shurd added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2019

azuresdkci assigned ArcturusZhang Sep 26, 2019

azuresdkci requested a review from ArcturusZhang September 26, 2019 20:22

ravbhatnagar reviewed Sep 28, 2019

View reviewed changes

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json Outdated Show resolved Hide resolved

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2019-08-01/cosmos-db.json Outdated Show resolved Hide resolved

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 28, 2019

ArcturusZhang requested changes Sep 29, 2019

View reviewed changes

This was referenced Oct 2, 2019

[AutoPR cosmos-db/resource-manager] Cosmos DB patch and multi-api support Azure/azure-sdk-for-python#7551

Closed

[AutoPR cosmos-db/resource-manager] Cosmos DB patch and multi-api support Azure/azure-sdk-for-go#5937

Merged

shurd requested a review from ravbhatnagar October 3, 2019 07:57

Sam Hurd added 5 commits October 7, 2019 09:22

adding patch support in new API version, adding multiapi support for …

620403e

…python, go, java, adding new property from database account resource, adding locations to response of database accounts

removing api kind from one example

86c5cb0

adding partition key version, removing new property from old api version

3857975

revert changes to old api swagger

a0153e2

rebasing and adding preview versions to sdk generation

b14e132

shurd force-pushed the cosmosDBPatch branch from 3b7573e to b14e132 Compare October 7, 2019 16:24

openapi-sdkautomation bot mentioned this pull request Oct 7, 2019

[AutoPR cosmosdb/resource-manager/v2015_04_08] Cosmos DB patch and multi-api support test-repo-billy/azure-sdk-for-java#506

Closed

create or update method with guidance in the description

032d4a3

AutorestCI mentioned this pull request Oct 18, 2019

[AutoPR cosmos-db/resource-manager] Cosmos DB patch and multi-api support Azure/azure-sdk-for-python#8008

Closed

Sam Hurd added 2 commits October 17, 2019 17:36

renaming create variables

5731ffb

minor text changes

b278a4f

ArcturusZhang approved these changes Oct 25, 2019

View reviewed changes

pilor approved these changes Oct 29, 2019

View reviewed changes

ArcturusZhang merged commit 86a2a68 into Azure:master Oct 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cosmos DB patch and multi-api support #7336

Cosmos DB patch and multi-api support #7336

shurd commented Sep 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading

azuresdkci commented Sep 26, 2019

ravbhatnagar left a comment

ArcturusZhang left a comment •

edited

Loading

shurd commented Sep 29, 2019

ArcturusZhang commented Sep 29, 2019

shurd commented Oct 2, 2019

ravbhatnagar commented Oct 17, 2019

shurd commented Oct 18, 2019

ArcturusZhang left a comment

Cosmos DB patch and multi-api support #7336

Cosmos DB patch and multi-api support #7336

Conversation

shurd commented Sep 26, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Sep 26, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from b278a4f, Iteration 9)

AutorestCI commented Sep 26, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Sep 26, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Sep 26, 2019

ravbhatnagar left a comment

Choose a reason for hiding this comment

ArcturusZhang left a comment • edited Loading

Choose a reason for hiding this comment

shurd commented Sep 29, 2019

ArcturusZhang commented Sep 29, 2019

shurd commented Oct 2, 2019

ravbhatnagar commented Oct 17, 2019

shurd commented Oct 18, 2019

ArcturusZhang left a comment

Choose a reason for hiding this comment

shurd commented Sep 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading

ArcturusZhang left a comment •

edited

Loading