Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new VirtualMachines.POST.Reapply action to compute api-version: 2019-07-01. Updating parameter info for skus api-version:2019-04-01.. #7167

Merged
merged 6 commits into from
Sep 20, 2019
Merged

Adding new VirtualMachines.POST.Reapply action to compute api-version: 2019-07-01. Updating parameter info for skus api-version:2019-04-01.. #7167

merged 6 commits into from
Sep 20, 2019

Conversation

avinashakka
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7378

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5765

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@avinashakka avinashakka changed the title Adding new VirtualMachines.POST.Reapply action to compute api-version: 2019-07-01. Adding new VirtualMachines.POST.Reapply action to compute api-version: 2019-07-01. Updating parameter info for skus api-version:2019-04-01.. Sep 12, 2019
This was referenced Sep 12, 2019
Closed
Merged
@AutorestCI AutorestCI mentioned this pull request Sep 12, 2019
Closed
@yungezz
Copy link
Member

yungezz commented Sep 17, 2019

hi @avinashakka since this is to merge into a private branch, what level of reviewing you'd like to have? an official reviewing as a normal spec PR or your internal team reviewing?

@avinashakka
Copy link
Contributor Author

hi @avinashakka since this is to merge into a private branch, what level of reviewing you'd like to have? an official reviewing as a normal spec PR or your internal team reviewing?

Hi @yungezz, Official. I have reviewed this change with my team and @hyonholee. Please go ahead and review it.

@weidongxu-microsoft
Copy link
Member

@avinashakka
PR look good to me. If you do not need ARM review, please just resolve the conflict on base branch and we could get it merged.

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2019
Merged
@weidongxu-microsoft weidongxu-microsoft merged commit 8809532 into Azure:compute-2019-07 Sep 20, 2019
zikalino pushed a commit that referenced this pull request Oct 20, 2019
@hyonholee
Compute 2019-07-01 version (#7094)
4a26ffa 
* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (#7173)

* temp fix

* Adding new VirtualMachines.POST.Reapply action to compute api-version: 2019-07-01. Updating parameter info for skus api-version:2019-04-01..  (#7167)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* Adding new VirtualMachines.POST.Reapply action.

* Adding example for POST Reapply virtual machine action.

* Adding missing $filter parameter documentation to skus.json for api-version: 2019-04-01.

* Unexpected change.

* Added DiskEnryptionSet property in the managed disk parameters for the VM/VMSS (#7293)

*  updated swagger

*  updated swagger

* Removed example files which are not relevant and added links to examples for newly added property

* fixed the syntax error

*  updated swagger

*  fixed the sytax error

* Added examples for the DiskEncryptionSet property (#7318)

*  updated swagger

*  updated swagger

* Removed example files which are not relevant and added links to examples for newly added property

* fixed the syntax error

*  updated swagger

*  fixed the sytax error

*  updated code

*  udpated swagger to create DiskEncryptionSet as new property to initiate

* Resolved conflicts with DiskRP definition names for the DiskEncryptionSet (#7340)

*  updated swagger

*  updated swagger

* Removed example files which are not relevant and added links to examples for newly added property

* fixed the syntax error

*  updated swagger

*  fixed the sytax error

*  updated code

*  udpated swagger to create DiskEncryptionSet as new property to initiate

* resolved conflicts and updated swagger due to conflict in the DiskRP definitions

* Disk 2019-07-01 version (#7280)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples (#7429)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples

* Add extension API for VMScaleset VMs (#7407)

* add extension Api

* change operationID

* update description

* update description

* add examples

* add missing /

* add missing / in examples

* add new line

* remove unnecessary file

* add reference examples

* fix model validation failures

* remove provisioning state from params

* remove unnecessary param

* fix Delete example

* updating the description of storage account id (#7385)

* Private temp (#7456)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples

* Remove uniqueId in swagger

* Remove required for diskEncryptionSetId

* cherry pick code owner change to compute-2019-07 (#7480)

* Iops, throughput and instance view (#7499)

* Swagger changes for IOPS, Bulk InstanceView, documentation for GETVM and InstanceView

* Fixed typos

* Updated samples

* Update 2019-07 from latest 2019-03 update.

* Update swagger (#7510)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples

* Remove uniqueId in swagger

* Remove required for diskEncryptionSetId

* Update principalId and tenantId to be readonly

* small space fix

* add update property (#7514)

* Sync with the latest 2019-03-01 version to 2019-07-01 version of compute.

* suppress LintDiff validation error.

* Add default responses to new APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@huangpf huangpf Awaiting requested review from huangpf

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@avinashakka @AutorestCI @azuresdkci @yungezz @weidongxu-microsoft @hyonholee @avinashakka09