Brooklyn Gateway Packet Capture feature #7151

Khushboo-Baheti · 2019-09-09T03:01:30Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-09-09T03:03:44Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-09T03:03:44Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpsd_xufe_/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpsd_xufe_/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4399/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[11055:0x34accc0]    68259 ms: Mark-sweep 1377.5 (1426.7) -> 1377.4 (1427.2) MB, 1401.1 / 0.0 ms  (average mu = 0.069, current mu = 0.002) allocation failure GC in old space requested
[11055:0x34accc0]    69657 ms: Mark-sweep 1378.0 (1427.2) -> 1378.0 (1427.7) MB, 1395.2 / 0.0 ms  (average mu = 0.036, current mu = 0.002) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xe818715be1d]
Security context: 0x1313d639e6e9 <JSObject>
    1: newScalar [0x1f750fa51fb9] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0xe81871e9df6](this=0x10978a2f0cf1 <Object map = 0x15092228e3e1>,v=0x32168d7026f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x1f750fa51ef9] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [pc=...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xe818715be1d

AutorestCI · 2019-09-09T03:35:46Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

...tion/network/resource-manager/Microsoft.Network/stable/2019-07-01/virtualNetworkGateway.json

...ft.Network/stable/2019-07-01/examples/VirtualNetworkGatewayConnectionStartPacketCapture.json

...tion/network/resource-manager/Microsoft.Network/stable/2019-07-01/virtualNetworkGateway.json

…Baheti/azure-rest-api-specs into network-august-release

anton-evseev

LGTM

anton-evseev · 2019-09-11T17:14:05Z

@pilor @KrisBash could you please review this PR?

pilor · 2019-09-11T23:22:20Z

...tion/network/resource-manager/Microsoft.Network/stable/2019-07-01/virtualNetworkGateway.json

+      "properties": {
+        "sasUrl": {
+          "type": "string",
+          "description": "SAS url for packet capture on VNG."


VNG isn't used anywhere else. Can we stick to the full name for descriptions?

pilor · 2019-09-11T23:23:01Z

...tion/network/resource-manager/Microsoft.Network/stable/2019-07-01/virtualNetworkGateway.json

+    },
+    "VpnPacketCaptureStartParameters": {
+      "properties": {
+        "filterData": {


Why is this modeled as a JSON string instead of a rich object? Where does the user get this filterData string from and how do they figure out the format?

This is modeled as a JSON to have more flexibility in publishing changes to filtering data. We are going to publish this JSON schema in public domain for the customer to refer to. We also plan to provide helper powershell command to generate JSON.

Discussed offline - given the scenario and requirements, this seems acceptable.

pilor · 2019-09-11T23:26:32Z

...tion/network/resource-manager/Microsoft.Network/stable/2019-07-01/virtualNetworkGateway.json

+            "$ref": "./network.json#/parameters/SubscriptionIdParameter"
+          }
+        ],
+        "responses": {


Its a good habit to map the default response to an error contract. See "networkWatcher.json" or some of the other network specs for examples. There is a shared definition in network.json.

anton-evseev · 2019-09-12T18:14:41Z

Since @pilor is OOF, @KrisBash could you please review this PR. Chris' comments were addressed

KrisBash

signing off for ARM

sergey-shandar · 2019-09-13T00:06:01Z

@pilor could you approve the changes?

anton-evseev · 2019-09-13T00:07:09Z

@sergey-shandar he's OOF today. Could you dismiss his review? @KrisBash approved on behalf of ARM team

* PacketCaptureOperationforVPNGateways * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionStopPacketCapture.json * Update VirtualNetworkGatewayStopPacketCapture.json * Update VirtualNetworkGatewayStopPacketCapture.json * Update VirtualNetworkGatewayConnectionStopPacketCapture.json * Update VirtualNetworkGatewayConnectionStartPacketCapture.json * Update VirtualNetworkGatewayStartPacketCapture.json * Update virtualNetworkGateway.json * fixing examples * fixing virtualNetworkGateway.json * fixing params * fixing path params * response body * example errors * example errors * example errors * filterdata * Update virtualNetworkGateway.json * fixing Comments * Fixing ARM Comments * Remove duplicate definition

* Adds base for updating Microsoft.Network from version stable/2019-06-01 to version 2019-07-01 * Updates readme * Updates API version in new specs and examples * Update API version in VMSS' specs (#7008) * Add reference to existing base definition & fix errors in descriptions of Network's provisioningState property (#7026) * Improve Network's descriptions (#6974) * New Skus and Generations for VirtualNetworkVpnGateways (#7089) * New Skus and generations for VirtualNetwork VpnGateways * Minor Typo fix * update avocado@0.6.0 (#7054) * Lock typescript version to fix compile error (#7068) * Fix description for vpnGatewayGeneration. * Add VirtualRouter top level resource Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink (#7005) * Fixed required properties in TrafficAnalyticsProperties: networkWatcehr.json (#7080) * Added traffic selector policy definition to virtualNetworkGateway.json (#7066) * Support for changes in ConnectionMonitor API (#7075) * Updating Network Config Diagnostics API desc (#7117) * Added priority field in the request routing rule (#7131) * Added priority field in the request routing rule * Added min and max * Minor * Added new owner to Azure Networking (#7145) added number213 to Az NW * Add Mssql value to Application Rule Type enum (#7169) * Add privateLinkConnectionProperties to network interface. (#7189) * Add privateLinkConnectionProperties to network interface on 2019-07-01. * Small changes for descriptions in the property. * make the new property to be read-only. * Brooklyn Gateway Packet Capture feature (#7151) * PacketCaptureOperationforVPNGateways * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionStopPacketCapture.json * Update VirtualNetworkGatewayStopPacketCapture.json * Update VirtualNetworkGatewayStopPacketCapture.json * Update VirtualNetworkGatewayConnectionStopPacketCapture.json * Update VirtualNetworkGatewayConnectionStartPacketCapture.json * Update VirtualNetworkGatewayStartPacketCapture.json * Update virtualNetworkGateway.json * fixing examples * fixing virtualNetworkGateway.json * fixing params * fixing path params * response body * example errors * example errors * example errors * filterdata * Update virtualNetworkGateway.json * fixing Comments * Fixing ARM Comments * Remove duplicate definition

PacketCaptureOperationforVPNGateways

6d1081a

Khushboo-Baheti requested review from MikhailTryakhov and anton-evseev as code owners September 9, 2019 03:01

azuresdkci assigned sergey-shandar Sep 9, 2019

azuresdkci requested a review from sergey-shandar September 9, 2019 03:02

Update virtualNetworkGateway.json

3e28f23

anton-evseev suggested changes Sep 9, 2019

View reviewed changes

...tion/network/resource-manager/Microsoft.Network/stable/2019-07-01/virtualNetworkGateway.json Outdated Show resolved Hide resolved

Khushboo-Baheti added 7 commits September 9, 2019 12:03

Update VirtualNetworkGatewayConnectionStopPacketCapture.json

22db055

Update VirtualNetworkGatewayStopPacketCapture.json

8fc7fca

Update VirtualNetworkGatewayStopPacketCapture.json

b82bba8

Update VirtualNetworkGatewayConnectionStopPacketCapture.json

042343e

Update VirtualNetworkGatewayConnectionStartPacketCapture.json

07149c4

Update VirtualNetworkGatewayStartPacketCapture.json

9bea8ff

Update virtualNetworkGateway.json

d80e69a

anton-evseev suggested changes Sep 9, 2019

View reviewed changes

...ft.Network/stable/2019-07-01/examples/VirtualNetworkGatewayConnectionStartPacketCapture.json Outdated Show resolved Hide resolved

Khushboo Baheti added 10 commits September 9, 2019 15:17

fixing examples

d3b726f

fixing virtualNetworkGateway.json

f621787

fixing params

c39ac9d

fixing path params

e4cb205

response body

3498c48

example errors

c5e957c

example errors

ee415fb

example errors

0a0cf46

filterdata

9ae29c8

Update virtualNetworkGateway.json

e176b50

anton-evseev suggested changes Sep 10, 2019

View reviewed changes

Merge branch 'network-august-release' of https://github.com/Khushboo-…

7aaae0d

…Baheti/azure-rest-api-specs into network-august-release

fixing Comments

5ed72f9

anton-evseev added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 10, 2019

anton-evseev approved these changes Sep 10, 2019

View reviewed changes

pilor suggested changes Sep 11, 2019

View reviewed changes

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 11, 2019

Khushboo Baheti and others added 2 commits September 11, 2019 17:11

Fixing ARM Comments

478a2a2

Remove duplicate definition

11bde8d

KrisBash approved these changes Sep 12, 2019

View reviewed changes

sergey-shandar approved these changes Sep 13, 2019

View reviewed changes

sergey-shandar merged commit a06e169 into Azure:network-august-release Sep 13, 2019

jiaczh mentioned this pull request Jul 7, 2020

add VpnGatewaypacketCapture api #9832

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Brooklyn Gateway Packet Capture feature #7151

Brooklyn Gateway Packet Capture feature #7151

Khushboo-Baheti commented Sep 9, 2019 •

edited

Loading

azuresdkci commented Sep 9, 2019

AutorestCI commented Sep 9, 2019 •

edited

Loading

AutorestCI commented Sep 9, 2019 •

edited

Loading

anton-evseev left a comment

anton-evseev commented Sep 11, 2019

pilor Sep 11, 2019

pilor Sep 11, 2019

Khushboo-Baheti Sep 11, 2019 •

edited

Loading

KrisBash Sep 12, 2019

pilor Sep 11, 2019

anton-evseev Sep 12, 2019

anton-evseev commented Sep 12, 2019

KrisBash left a comment

sergey-shandar commented Sep 13, 2019

anton-evseev commented Sep 13, 2019

Brooklyn Gateway Packet Capture feature #7151

Brooklyn Gateway Packet Capture feature #7151

Conversation

Khushboo-Baheti commented Sep 9, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Sep 9, 2019

AutorestCI commented Sep 9, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 9, 2019 • edited Loading

Automation for azure-sdk-for-go

anton-evseev left a comment

Choose a reason for hiding this comment

anton-evseev commented Sep 11, 2019

pilor Sep 11, 2019

Choose a reason for hiding this comment

pilor Sep 11, 2019

Choose a reason for hiding this comment

Khushboo-Baheti Sep 11, 2019 • edited Loading

Choose a reason for hiding this comment

KrisBash Sep 12, 2019

Choose a reason for hiding this comment

pilor Sep 11, 2019

Choose a reason for hiding this comment

anton-evseev Sep 12, 2019

Choose a reason for hiding this comment

anton-evseev commented Sep 12, 2019

KrisBash left a comment

Choose a reason for hiding this comment

sergey-shandar commented Sep 13, 2019

anton-evseev commented Sep 13, 2019

Khushboo-Baheti commented Sep 9, 2019 •

edited

Loading

AutorestCI commented Sep 9, 2019 •

edited

Loading

AutorestCI commented Sep 9, 2019 •

edited

Loading

Khushboo-Baheti Sep 11, 2019 •

edited

Loading