Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Virtual Router top level resource. Add Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink #7005

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Add Virtual Router top level resource. Add Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink #7005

merged 1 commit into from
Sep 5, 2019

Conversation

naveenchekuri
Copy link
Contributor

@naveenchekuri naveenchekuri commented Aug 20, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 20, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from a93e01b, Iteration 5)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning network/resource-manager/v2017_10_01 [Logs]
  • Warning network/resource-manager/v2018_04_01 [Logs]
  • Warning network/resource-manager/v2018_06_01 [Logs]
  • Warning network/resource-manager/v2018_07_01 [Logs]
  • Warning network/resource-manager/v2018_08_01 [Logs]
  • Warning network/resource-manager/v2018_12_01 [Logs]
  • Warning network/resource-manager/v2019_02_01 [Logs]
  • Warning network/resource-manager/v2019_04_01 [Logs]
  • Warning network/resource-manager/v2019_06_01 [Logs]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • No packages generated.
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from lirenhe August 20, 2019 23:36
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmphdwvrzyb/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmphdwvrzyb/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4392/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4392)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[18400:0x3870cc0]    99363 ms: Mark-sweep 1380.2 (1426.1) -> 1380.1 (1426.6) MB, 2361.0 / 0.0 ms  (average mu = 0.168, current mu = 0.092) allocation failure GC in old space requested
[18400:0x3870cc0]   101766 ms: Mark-sweep 1381.0 (1426.6) -> 1380.9 (1427.1) MB, 2399.1 / 0.0 ms  (average mu = 0.087, current mu = 0.001) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x1f9bdc05be1d]
Security context: 0x2641d7a9e6e9 <JSObject>
    1: newScalar [0x1e3d69f38801] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0x1f9bdc794096](this=0x084b1be55759 <Object map = 0x8ed2c022cd9>,v=0x0ab21a7026f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x2d8bb6948cd9] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [pc...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x1f9bdc05be1d

@naveenchekuri naveenchekuri changed the title [Hub Generated] Review request for Microsoft.Network to add version stable/2019-06-01 Add Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink Aug 20, 2019
@AutorestCI AutorestCI mentioned this pull request Aug 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5599

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2019
@anton-evseev anton-evseev changed the base branch from master to network-august-release August 21, 2019 03:12
@anton-evseev
Copy link
Contributor

Updated commit to the next API version (2019-07-01) and re-targeted to network-august-release

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 21, 2019
Closed
@AutorestCI AutorestCI mentioned this pull request Aug 22, 2019
Merged
@naveenchekuri naveenchekuri changed the title Add Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink Add Virtual Router top level resource. Add Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink Aug 23, 2019
@sanjaiganesh sanjaiganesh added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 24, 2019
anthony-c-martin
anthony-c-martin requested changes Aug 28, 2019
View reviewed changes
@anthony-c-martin anthony-c-martin mentioned this pull request Aug 29, 2019
Closed
5 tasks
anthony-c-martin
anthony-c-martin approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Aug 29, 2019
@naveenchekuri
Copy link
Contributor Author

@lirenhe and @number213 ARM team has signed off on the PR. Could you sign off as well

@anton-evseev
Copy link
Contributor

@anthony-c-martin I'm still concerned about PATCH operations' operationId. I think if should be _UpdateTags since it only updates tags and that's how such operations are named in other Network specs. But previous ARM reviewer insisted on using _Update.

@anton-evseev
Copy link
Contributor

@lirenhe could you please take a look at CI failures? Maybe network-august-release is missing some updates from master? Could you please merge master into our release branch?

@anthony-c-martin
Copy link
Member

@number213 @naveenchekuri _UpdateTags sounds fine to me if it's consistent with your other API declarations, and you don't support patching any other resource properties.

@anton-evseev
Copy link
Contributor

Sounds good! @naveenchekuri could you please update two operationIds to use _UpdateTags?

@naveenchekuri
Copy link
Contributor Author

@number213 Done. Made changes to set as UpdateTags

@lirenhe
Copy link
Member

lirenhe commented Aug 30, 2019

@naveenchekuri I saw there are a couple of check errors which is a regression issue on our side. So to solve those check errors, could you sync the code from master to your working branch?

@PhoenixHe-NV
Copy link
Contributor

@naveenchekuri Please pick this PR #7068 or merge from master to fix the CI

@anton-evseev
Copy link
Contributor

Hi, @lirenhe, I've cherry picked two commit that solved CI errors. SDK java is failing due to timeout as usual, can we get this PR merged?
Also, regarding SDK java... Could we try bumping timeout in SwaggerToSDK.yml to 3 hours? Azure DevOps supports timeouts up to 6 hours for public pipelines, maybe that would resolve our issues.

@PhoenixHe-NV
Copy link
Contributor

@number123 I'm the owner of the swagger to sdk automation. I'm not aware of that the automation need to run that long of time. I need to confirm that does it really need over than an hour to generate SDK？

@anton-evseev
Copy link
Contributor

anton-evseev commented Aug 31, 2019 via email

@anton-evseev
Copy link
Contributor

@lirenhe @NullMDR gentle ping

@naveenchekuri
Copy link
Contributor Author

@lirenhe @NullMDR. We need to commit the PR before 09. please help with this

@PhoenixHe-NV
Copy link
Contributor

PhoenixHe-NV commented Sep 4, 2019 •
edited
Loading

@yungezz please force merge this one. The timeout issue will be fixed in the new automation.

@naveenchekuri @anton-evseev
Add VirtualRouter top level resource Identity under Microsoft.Network…
d771c4b 
…/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink
@anton-evseev
Copy link
Contributor

Rebased PR to include fixes for CI that were merged into network-august-branch recently

@naveenchekuri
Copy link
Contributor Author

@yungezz could you please merge the PR

@yungezz yungezz merged commit 9818c82 into Azure:network-august-release Sep 5, 2019
anton-evseev pushed a commit to anton-evseev/azure-rest-api-specs that referenced this pull request Sep 13, 2019
@naveenchekuri @anton-evseev
Add VirtualRouter top level resource Identity under Microsoft.Network…
1494051 
…/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink (Azure#7005)
sarangan12 pushed a commit that referenced this pull request Sep 13, 2019
@anton-evseev @sarangan12
Network August release (#7208)
a3a1f28 
* Adds base for updating Microsoft.Network from version stable/2019-06-01 to version 2019-07-01

* Updates readme

* Updates API version in new specs and examples

* Update API version in VMSS' specs (#7008)

* Add reference to existing base definition & fix errors in descriptions of Network's provisioningState property (#7026)

* Improve Network's descriptions (#6974)

* New Skus and Generations for VirtualNetworkVpnGateways (#7089)

* New Skus and generations for VirtualNetwork VpnGateways

* Minor Typo fix

* update avocado@0.6.0 (#7054)

* Lock typescript version to fix compile error (#7068)

* Fix description for vpnGatewayGeneration.

* Add VirtualRouter top level resource Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink (#7005)

* Fixed required properties in TrafficAnalyticsProperties: networkWatcehr.json (#7080)

* Added traffic selector policy definition to virtualNetworkGateway.json (#7066)

* Support for changes in ConnectionMonitor API (#7075)

* Updating Network Config Diagnostics API desc (#7117)

* Added priority field in the request routing rule (#7131)

* Added priority field in the request routing rule

* Added min and max

* Minor

* Added new owner to Azure Networking (#7145)

added number213 to Az NW

* Add Mssql value to Application Rule Type enum (#7169)

* Add privateLinkConnectionProperties to network interface. (#7189)

* Add privateLinkConnectionProperties to network interface on 2019-07-01.

* Small changes for descriptions in the property.

* make the new property to be read-only.

* Brooklyn Gateway Packet Capture feature (#7151)

* PacketCaptureOperationforVPNGateways

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionStopPacketCapture.json

* Update VirtualNetworkGatewayStopPacketCapture.json

* Update VirtualNetworkGatewayStopPacketCapture.json

* Update VirtualNetworkGatewayConnectionStopPacketCapture.json

* Update VirtualNetworkGatewayConnectionStartPacketCapture.json

* Update VirtualNetworkGatewayStartPacketCapture.json

* Update virtualNetworkGateway.json

* fixing examples

* fixing virtualNetworkGateway.json

* fixing params

* fixing path params

* response body

* example errors

* example errors

* example errors

* filterdata

* Update virtualNetworkGateway.json

* fixing Comments

* Fixing ARM Comments

* Remove duplicate definition
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@dolauli
Enable azure powershell CI in RPSaaSMaster branch (Azure#7005)
7f8c2bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@anton-evseev anton-evseev anton-evseev approved these changes

@lirenhe lirenhe lirenhe approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@PhoenixHe-NV PhoenixHe-NV

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@naveenchekuri @azuresdkci @AutorestCI @anton-evseev @anthony-c-martin @lirenhe @PhoenixHe-NV @sanjaiganesh @yungezz