-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFactory]Fix a typo for binary sink #6943
Conversation
Merge from azure master
merge from master
In Testing, Please Ignore[Logs] (Generated from 65a2679, Iteration 4)
|
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
This should not be a risk change, test for SDK has already worked for "writeSetting", it is just a typo error, see the test payload in line 4112 of https://github.com/Azure/azure-sdk-for-net/blob/192d01dd78d4243ed0dbb097f59e444ff98604d6/sdk/datafactory/Microsoft.Azure.Management.DataFactory/tests/JsonSamples/PipelineJsonSamples.cs, the test has already passed. |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
@NullMDR Do you know why CI hasn't been completed for a day? |
Bug in CI. Waiting for engineering team to fix it. |
@NullMDR @Juliehzl Do you know what's the ETA of the fixing? Or re-create the pull request may solve this problem? I need to merge it by end of tomorrow, since we have an deadline for SDK/powershell release. |
just to double confirm, @TinaHu1 is this PR to fix a bug in Swagger file, otherwise it will be a breaking change. |
@Juliehzl Could you help review this PR? Thanks a lot. |
Yes, it is a bug fix. |
CI tasks passed in Azure Pipeline, detail pls see https://dev.azure.com/azure-sdk/public/_build/results?buildId=87546&view=results. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.