Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory]Fix a typo for binary sink #6943

Merged
merged 3 commits into from
Aug 14, 2019

Conversation

TinaHu1
Copy link
Contributor

@TinaHu1 TinaHu1 commented Aug 13, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2019

In Testing, Please Ignore

[Logs] (Generated from 65a2679, Iteration 4)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
Pending Go: test-repo-billy/azure-sdk-for-go
  • Package generation pending.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@TinaHu1
Copy link
Contributor Author

TinaHu1 commented Aug 13, 2019

This should not be a risk change, test for SDK has already worked for "writeSetting", it is just a typo error, see the test payload in line 4112 of https://github.com/Azure/azure-sdk-for-net/blob/192d01dd78d4243ed0dbb097f59e444ff98604d6/sdk/datafactory/Microsoft.Azure.Management.DataFactory/tests/JsonSamples/PipelineJsonSamples.cs, the test has already passed.

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5507

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@Juliehzl
Copy link
Contributor

@NullMDR Do you know why CI hasn't been completed for a day?

@PhoenixHe-NV
Copy link
Contributor

Bug in CI. Waiting for engineering team to fix it.

@TinaHu1
Copy link
Contributor Author

TinaHu1 commented Aug 14, 2019

@NullMDR @Juliehzl Do you know what's the ETA of the fixing? Or re-create the pull request may solve this problem? I need to merge it by end of tomorrow, since we have an deadline for SDK/powershell release.

@PhoenixHe-NV
Copy link
Contributor

PhoenixHe-NV commented Aug 14, 2019

@yungezz CI actually passed and blocked by the known issue about sync. Please help to merge. But @TinaHu1 currently it's not approved yet...

@yungezz
Copy link
Member

yungezz commented Aug 14, 2019

just to double confirm, @TinaHu1 is this PR to fix a bug in Swagger file, otherwise it will be a breaking change.

@TinaHu1
Copy link
Contributor Author

TinaHu1 commented Aug 14, 2019

@Juliehzl Could you help review this PR? Thanks a lot.

@TinaHu1
Copy link
Contributor Author

TinaHu1 commented Aug 14, 2019

just to double confirm, @TinaHu1 is this PR to fix a bug in Swagger file, otherwise it will be a breaking change.

Yes, it is a bug fix.

@yungezz
Copy link
Member

yungezz commented Aug 14, 2019

CI tasks passed in Azure Pipeline, detail pls see https://dev.azure.com/azure-sdk/public/_build/results?buildId=87546&view=results.

@yungezz yungezz merged commit dba7982 into Azure:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants