Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataFactory] Event Trigger Subscription APIs #6893

Merged
merged 1 commit into from
Aug 14, 2019
Merged

[DataFactory] Event Trigger Subscription APIs #6893

merged 1 commit into from
Aug 14, 2019

Conversation

cesher
Copy link
Contributor

@cesher cesher commented Aug 7, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 7, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 4e558e7, Iteration 8)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@azuresdkci azuresdkci requested a review from jhendrixMSFT August 7, 2019 19:45
@AutorestCI AutorestCI mentioned this pull request Aug 7, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI AutorestCI mentioned this pull request Aug 7, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 7, 2019
hvermis
hvermis approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@hvermis hvermis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address last 2 comments

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 12, 2019
Closed
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 12, 2019
Closed
@jhendrixMSFT
Copy link
Member

Looks good from SDK perspective, waiting for ARM to sign off.

@hvermis
Copy link
Contributor

hvermis commented Aug 13, 2019

@jhendrixMSFT Who is on call from ARM PMs this week?

@jhendrixMSFT
Copy link
Member

@ryansbenson is the ARM on-call this week

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2019
@jhendrixMSFT jhendrixMSFT reopened this Aug 14, 2019
@AutorestCI AutorestCI mentioned this pull request Aug 14, 2019
Merged
This was referenced Aug 14, 2019
Merged
Merged
@jhendrixMSFT jhendrixMSFT merged commit e70e82a into Azure:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cesher @AutorestCI @azuresdkci @jhendrixMSFT @hvermis @ravbhatnagar