Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary dataset in swagger #6569

Closed
wants to merge 4 commits into from
Closed

Add binary dataset in swagger #6569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d36a561
Add binary dataset in swagger
TinaHu18 Jul 9, 2019
4a41a1d
Merge branch 'master' into binary
TinaHu1 Jul 9, 2019
25fb8b6
add binary sink
TinaHu18 Jul 11, 2019
d580034
add type for binary type properties
TinaHu18 Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions ...factory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,40 @@
"location"
]
},
"BinaryDataset": {
"x-ms-discriminator-value": "Binary",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new polymorphic child to an existing stable api version constitutes a breaking change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey Amar, we've been adding new types all the time, and our customers are aware. If we had to create new API version for every type we would have tons API versions. It is not scalable.

"description": "Binary dataset.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/Dataset"
}
],
"properties": {
"typeProperties": {
"description": "Binary dataset properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/BinaryDatasetTypeProperties"
}
}
},
"BinaryDatasetTypeProperties": {
"description": "Binary dataset properties.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "type": "object",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you help review the pull request again? We need to merge our change as soon as possible to release our SDK and catch up the ETA of powershell release. Thanks.

"type": "object",
"properties": {
"location": {
"$ref": "#/definitions/DatasetLocation",
"description": "The location of the Binary storage."
},
"compression": {
"description": "The data compression method used for the binary dataset.",
"$ref": "#/definitions/DatasetCompression"
}
},
"required": [
"location"
]
},
"AzureBlobDataset": {
"x-ms-discriminator-value": "AzureBlob",
"description": "The Azure Blob storage.",
Expand Down
30 changes: 30 additions & 0 deletions ...actory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,21 @@
"type"
]
},
"BinarySource": {
"description": "A copy activity Binary source.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/CopySource"
}
],
"properties": {
"storeSettings": {
"$ref": "#/definitions/StoreReadSettings",
"description": "Binary store settings."
}
}
},
"AzureTableSource": {
"description": "A copy activity Azure Table source.",
"type": "object",
Expand Down Expand Up @@ -2171,6 +2186,21 @@
}
}
},
"BinarySink": {
"description": "A copy activity Binary sink.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/CopySink"
}
],
"properties": {
"storeSettings": {
"$ref": "#/definitions/StoreReadSettings",
"description": "Binary store settings."
}
}
},
"BlobSink": {
"description": "A copy activity Azure Blob sink.",
"type": "object",
Expand Down