Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before #6485

Merged
merged 31 commits into from
Jul 8, 2019
Merged

BUG fix: Fixing type of MetricValue.Count to be double instead of the incorrect int64 it had before #6485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
00a5689
[Monitor] Make all attributes of EventData class readonly (#2254)
gucalder Feb 7, 2018
b0ca590
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Feb 9, 2018
8c3746f
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Feb 17, 2018
799c13f
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Feb 28, 2018
067e5a9
[Monitor] Fixing issue with metricnamespace specification as client l…
gucalder Mar 1, 2018
5c64ca3
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Mar 10, 2018
a227d3f
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Mar 14, 2018
189d112
[Monitor] Fixing incorrect specification of top parameter for Metrics…
gucalder Mar 14, 2018
e0ff7d6
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Mar 15, 2018
5adef1e
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 1, 2018
4c653be
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 7, 2018
3b52ba4
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 12, 2018
4afd2b6
Add two missing "by subscription" operations.
gucalder Jun 21, 2018
840fcf1
Remove "examples" nodes as requested since they are not used anymore.…
gucalder Jun 21, 2018
8e22a06
Add the serviceBusRuleId back into the DiagnosticSetting resource spec.
gucalder Jun 22, 2018
cc4855d
Fix some issues with the examples
gucalder Jun 23, 2018
3c3f34d
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 23, 2018
03bdcd7
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 25, 2018
9068f5e
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Aug 3, 2018
10e9834
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Aug 6, 2018
1ca7f22
[Monitor] Fix issue #3585: revert previous commit since it is a break…
gucalder Aug 6, 2018
0ab44af
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Aug 7, 2018
67216df
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 24, 2019
e55d50c
Add unit "BitsPerSecond" to the metrics specs.
gucalder Jun 25, 2019
e14f5f8
Fixing workspace Id documentation
gucalder Jun 25, 2019
d177b96
Add the Log Analytics destination type flag to the Diagnostic Setting…
gucalder Jun 26, 2019
6a8e159
Fix a typo in a description
gucalder Jun 26, 2019
4668346
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 27, 2019
0602217
Fixing type of MetricValue.Count to be double instead of the incorrec…
gucalder Jun 27, 2019
2af54a5
Fixing issue #2467 In List Activity Logs $filter is not optional and …
gucalder Jun 28, 2019
5251be8
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions ...ation/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/activityLogs_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
"name": "$filter",
"in": "query",
"type": "string",
"required": false,
"description": "Reduces the set of data collected.<br>The **$filter** argument is very restricted and allows only the following patterns.<br>- *List events for a resource group*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and resourceGroupName eq 'resourceGroupName'.<br>- *List events for resource*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and resourceUri eq 'resourceURI'.<br>- *List events for a subscription in a time range*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z'.<br>- *List events for a resource provider*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and resourceProvider eq 'resourceProviderName'.<br>- *List events for a correlation Id*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and correlationId eq 'correlationID'.<br><br>**NOTE**: No other syntax is allowed."
"required": true,
"description": "Reduces the set of data collected.<br>This argument is required and it also requires at least the start date/time.<br>The **$filter** argument is very restricted and allows only the following patterns.<br>- *List events for a resource group*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and resourceGroupName eq 'resourceGroupName'.<br>- *List events for resource*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and resourceUri eq 'resourceURI'.<br>- *List events for a subscription in a time range*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z'.<br>- *List events for a resource provider*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and resourceProvider eq 'resourceProviderName'.<br>- *List events for a correlation Id*: $filter=eventTimestamp ge '2014-07-16T04:36:37.6407898Z' and eventTimestamp le '2014-07-20T04:36:37.6407898Z' and correlationId eq 'correlationID'.<br><br>**NOTE**: No other syntax is allowed."
},
{
"$ref": "#/parameters/SelectParameter"
Expand Down Expand Up @@ -80,14 +80,8 @@
},
"x-ms-odata": "#/definitions/EventData",
"x-ms-examples": {
"Get Activity Logs without filter or select": {
"$ref": "./examples/GetActivityLogsNoParams.json"
},
"Get Activity Logs with filter": {
"$ref": "./examples/GetActivityLogsFiltered.json"
},
"Get Activity Logs with select": {
"$ref": "./examples/GetActivityLogsSelected.json"
"Get Activity Logs with filter": {
"$ref": "./examples/GetActivityLogsFiltered.json"
},
"Get Activity Logs with filter and select": {
"$ref": "./examples/GetActivityLogsFilteredAndSelected.json"
Expand Down
84 changes: 0 additions & 84 deletions ...source-manager/Microsoft.Insights/stable/2015-04-01/examples/GetActivityLogsNoParams.json
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions ...source-manager/Microsoft.Insights/stable/2015-04-01/examples/GetActivityLogsSelected.json
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metrics_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@
"description": "the sum of all of the values in the time range."
},
"count": {
"type": "integer",
"format": "int64",
"type": "number",
"format": "double",
Copy link
Contributor

@nschonni nschonni Jun 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like "count" should be a whole number. Can you get a count of 1.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, we discuss whether to change it in the backend (and leave this spec as it was) or change it in the spec. The reason for it to be a double (NOTE: we do not generate the metric, we just pass it on) is uncertain, but it might have something to do with the fact that this could actually be the average of several counts.

We thought that it after that, we decided to change the spec to reflect the current response of the backend to minimize customer impact.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, you might consider changing the name in the future then, since a count shouldn't be able to be a double AFAIK

"description": "the number of samples in the time range. Can be used to determine the number of values that contributed to the average value."
}
},
Expand Down