[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) #6422

orparnes · 2019-06-23T14:04:11Z

Latest improvements:

See also #5649 - Introducing assessments and assessmentsMetadata types

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-23T14:04:13Z

In Testing, Please Ignore

[Logs] (Generated from a81cc54, Iteration 32)

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/security/mgmt/v1.0 [Logs]
preview/security/mgmt/v2.0 [Logs] [Instructions] [Generation PR]
- preview.security.mgmt.v2.0.zip
preview/security/mgmt/v3.0 [Logs] [Instructions] [Generation PR]
- preview.security.mgmt.v3.0.zip

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-security [Logs] [Instructions] [Generation PR]
- azure-mgmt-security-0.2.0.zip
- azure_mgmt_security-0.2.0-py2.py3-none-any.whl

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-security [Logs]

AutorestCI · 2019-06-23T14:04:57Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3732ca83fad20b58fc7b320e09fca9c4dd2161f8
  stderr: 'fatal: reference is not a tree: 3732ca83fad20b58fc7b320e09fca9c4dd2161f8'

azuresdkci · 2019-06-23T14:05:02Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-23T14:05:16Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3732ca83fad20b58fc7b320e09fca9c4dd2161f8
  stderr: 'fatal: reference is not a tree: 3732ca83fad20b58fc7b320e09fca9c4dd2161f8'

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subassessments.json

AutorestCI · 2019-06-23T14:05:19Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-23T14:05:41Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

....Security/preview/2019-01-01-preview/examples/SubAssessments/ListSubAssessments_example.json

nschonni

CVSS can be added to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt to ignore it from the spellcheck

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subassessments.json

nschonni

PS: Think there may be a "format" way to express the date. "format": "date-time"

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json

nschonni

Mostly camelCase stuff

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json

custom-words.txt

...ft.Security/preview/2019-01-01-preview/examples/SubAssessments/GetSubAssessment_example.json

....Security/preview/2019-01-01-preview/examples/SubAssessments/ListSubAssessments_example.json

...ft.Security/preview/2019-01-01-preview/examples/SubAssessments/GetSubAssessment_example.json

....Security/preview/2019-01-01-preview/examples/SubAssessments/ListSubAssessments_example.json

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json

…ent" type, fix examples, add field, edit status object

ravbhatnagar

@orparnes - please set up a 30 min call to close on this. Its not clear whether subassessment is the right model as a nested type. so need to understand the usecases a little better.

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json

Add fields to ContainerRegistryVulnerabilityProperties and ServerVulnerabilityProperties

shahabhijeet · 2019-08-02T19:55:16Z

@orparnes please resolve merging conflicts

yungezz · 2019-08-26T07:45:07Z

hi @orparnes what's your plan on this "DoNotMerge" PR? it's been there 2 months. Is it ok to merge it now? or how about close it for now and reopen if ready for merge?

…y provider) (#7101) * sub assessment subscription level API * sub assessment subscription level API new line * sub assessment subscription level API new line 2 more files * sub assessment subscription level API removed redondent param * sub assessment subscription level API read me * sub assessment subscription level API read me * sub assessment subscription level API single fix * Added assessment scope API * update operation id on list all

nschonni · 2019-10-11T06:09:51Z

Looks like this got replaced by #7101

orparnes commented Jun 23, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subassessments.json Outdated Show resolved Hide resolved

azuresdkci assigned shahabhijeet Jun 23, 2019

azuresdkci requested a review from shahabhijeet June 23, 2019 14:05

orparnes commented Jun 23, 2019

View reviewed changes

....Security/preview/2019-01-01-preview/examples/SubAssessments/ListSubAssessments_example.json Outdated Show resolved Hide resolved

Add sub-assessment resource to Microsoft.Security provider

5810c80

nschonni reviewed Jun 23, 2019

View reviewed changes

nschonni reviewed Jun 25, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

Fix typos, Add custom words, Descriptions, Renames, Examples

dc4dc68

nschonni reviewed Jun 25, 2019

View reviewed changes

orparnes commented Jun 25, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

Add: ResourceDetails, custom words. Fix: examples, typos.

884ac56

chlahav self-requested a review June 30, 2019 11:12

chlahav added DoNotMerge <valid label in PR review process> use to hold merge after approval WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 30, 2019

Rename "extendedData" to "additionalData" to be aligned with "assessm…

cd0227d

…ent" type, fix examples, add field, edit status object

ravbhatnagar reviewed Jul 1, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 1, 2019

Renames

43468cc

sanjaiganesh reviewed Jul 3, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

sanjaiganesh reviewed Jul 5, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

sanjaiganesh reviewed Jul 6, 2019

View reviewed changes

.../security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json Outdated Show resolved Hide resolved

Resolve some issues, set spaces instead of tabs,

f5bd294

Add fields to ContainerRegistryVulnerabilityProperties and ServerVulnerabilityProperties

orparnes added 2 commits July 14, 2019 14:08

Fix example

b4e8dab

x-ms-enum fix

0917ba8

Remove some fields

92f4a95

AutorestCI mentioned this pull request Jul 24, 2019

[AutoPR security/resource-manager] Introducing subAssessments type (Microsoft.Security provider) Azure/azure-sdk-for-go#5328

Closed

shahabhijeet removed their assignment Aug 2, 2019

Merge branch 'master' into master

a81cc54

yungezz changed the title ~~Introducing subAssessments type (Microsoft.Security provider)~~ [DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) Aug 12, 2019

yungezz self-assigned this Aug 28, 2019

himarkov mentioned this pull request Sep 2, 2019

[Re-open of #6422] Introducing subAssessments type (Microsoft.Security provider) #7101

Merged

5 tasks

yungezz closed this Oct 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) #6422

[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) #6422

orparnes commented Jun 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 23, 2019 •

edited

Loading

AutorestCI commented Jun 23, 2019 •

edited

Loading

azuresdkci commented Jun 23, 2019

AutorestCI commented Jun 23, 2019 •

edited

Loading

AutorestCI commented Jun 23, 2019 •

edited

Loading

AutorestCI commented Jun 23, 2019 •

edited

Loading

nschonni left a comment

nschonni left a comment •

edited

Loading

nschonni left a comment

ravbhatnagar left a comment

shahabhijeet commented Aug 2, 2019

yungezz commented Aug 26, 2019

nschonni commented Oct 11, 2019

[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) #6422

[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) #6422

Conversation

orparnes commented Jun 23, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 23, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from a81cc54, Iteration 32)

AutorestCI commented Jun 23, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Jun 23, 2019

AutorestCI commented Jun 23, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 23, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 23, 2019 • edited Loading

Automation for azure-sdk-for-java

nschonni left a comment

Choose a reason for hiding this comment

nschonni left a comment • edited Loading

Choose a reason for hiding this comment

nschonni left a comment

Choose a reason for hiding this comment

ravbhatnagar left a comment

Choose a reason for hiding this comment

shahabhijeet commented Aug 2, 2019

yungezz commented Aug 26, 2019

nschonni commented Oct 11, 2019

orparnes commented Jun 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 23, 2019 •

edited

Loading

AutorestCI commented Jun 23, 2019 •

edited

Loading

AutorestCI commented Jun 23, 2019 •

edited

Loading

AutorestCI commented Jun 23, 2019 •

edited

Loading

AutorestCI commented Jun 23, 2019 •

edited

Loading

nschonni left a comment •

edited

Loading